From: "Anna Schumaker" <anna@kernel.org>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
NeilBrown <neil@brown.name>, "Jeff Layton" <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, llvm@lists.linux.dev
Cc: "Trond Myklebust" <trondmy@kernel.org>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>
Subject: Re: [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
Date: Wed, 04 Feb 2026 10:53:26 -0500 [thread overview]
Message-ID: <5bdb5b9d-30eb-4511-b839-21b073a6ce43@app.fastmail.com> (raw)
In-Reply-To: <20260204094500.2443455-2-andriy.shevchenko@linux.intel.com>
On Wed, Feb 4, 2026, at 4:41 AM, Andy Shevchenko wrote:
> Clang compiler is not happy about set but unused variable
> (when dprintk() is no-op):
>
> .../blocklayout/blocklayout.c:384:9: error: variable 'count' set but
> not used [-Werror,-Wunused-but-set-variable]
>
> Remove a leftover from the previous cleanup.
>
> Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write
> handling in bl_write_pagelist")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Anna Schumaker <anna.schumkaer@oracle.com>
> ---
> fs/nfs/blocklayout/blocklayout.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.c
> b/fs/nfs/blocklayout/blocklayout.c
> index 0e4c67373e4f..83e4a32b3018 100644
> --- a/fs/nfs/blocklayout/blocklayout.c
> +++ b/fs/nfs/blocklayout/blocklayout.c
> @@ -381,14 +381,13 @@ bl_write_pagelist(struct nfs_pgio_header *header,
> int sync)
> sector_t isect, extent_length = 0;
> struct parallel_io *par = NULL;
> loff_t offset = header->args.offset;
> - size_t count = header->args.count;
> struct page **pages = header->args.pages;
> int pg_index = header->args.pgbase >> PAGE_SHIFT;
> unsigned int pg_len;
> struct blk_plug plug;
> int i;
>
> - dprintk("%s enter, %zu@%lld\n", __func__, count, offset);
> + dprintk("%s enter, %u@%lld\n", __func__, header->args.count, offset);
>
> /* At this point, header->page_aray is a (sequential) list of nfs_pages.
> * We want to write each, and if there is an error set pnfs_error
> @@ -429,7 +428,6 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
> }
>
> offset += pg_len;
> - count -= pg_len;
> isect += (pg_len >> SECTOR_SHIFT);
> extent_length -= (pg_len >> SECTOR_SHIFT);
> }
> --
> 2.50.1
next prev parent reply other threads:[~2026-02-04 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 9:41 [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues Andy Shevchenko
2026-02-04 9:41 ` [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist() Andy Shevchenko
2026-02-04 15:53 ` Anna Schumaker [this message]
2026-02-04 16:44 ` Andy Shevchenko
2026-02-04 9:41 ` [PATCH v2 2/3] sunrpc: Kill RPC_IFDEBUG() Andy Shevchenko
2026-02-04 9:41 ` [PATCH v2 3/3] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op Andy Shevchenko
2026-02-04 16:46 ` Andy Shevchenko
2026-02-04 16:58 ` Andy Shevchenko
2026-02-04 18:29 ` Chuck Lever
2026-02-04 20:25 ` Andy Shevchenko
2026-02-04 10:02 ` [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues Andy Shevchenko
2026-02-04 14:28 ` Jeff Layton
2026-02-04 14:30 ` Chuck Lever
2026-02-04 14:45 ` Andy Shevchenko
2026-02-04 14:32 ` Andy Shevchenko
2026-02-04 15:42 ` Chuck Lever
2026-02-04 15:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdb5b9d-30eb-4511-b839-21b073a6ce43@app.fastmail.com \
--to=anna@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®