mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Jin <joe.jin@oracle.com>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	iommu@lists.linux-foundation.org, konrad.wilk@oracle.com
Cc: linux-kernel@vger.kernel.org, hch@lst.de,
	m.szyprowski@samsung.com, robin.murphy@arm.com,
	haakon.bugge@oracle.com
Subject: Re: [PATCH 1/1] swiotlb: save io_tlb_used to local variable before leaving critical section
Date: Fri, 12 Apr 2019 07:13:59 -0700	[thread overview]
Message-ID: <5bdc3265-e5a4-e8c8-9098-0bba18a66f19@oracle.com> (raw)
In-Reply-To: <1555069106-2964-1-git-send-email-dongli.zhang@oracle.com>

I'm good to have this patch, which helps identify the cause of failure is
fragmentation or it really been used up.

On 4/12/19 4:38 AM, Dongli Zhang wrote:
> When swiotlb is full, the kernel would print io_tlb_used. However, the
> result might be inaccurate at that time because we have left the critical
> section protected by spinlock.
> 
> Therefore, we backup the io_tlb_used into local variable before leaving
> critical section.
> 
> Fixes: 83ca25948940 ("swiotlb: dump used and total slots when swiotlb buffer is full")
> Suggested-by: Håkon Bugge <haakon.bugge@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>

Reviewed-by: Joe Jin <joe.jin@oracle.com> 

Thanks,
Joe


  reply	other threads:[~2019-04-12 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 11:38 Dongli Zhang
2019-04-12 14:13 ` Joe Jin [this message]
2019-04-15  6:50   ` Dongli Zhang
     [not found]     ` <CAPbh3rvyVd_D9tMfE-Bo2JmdabaiQnaipmmadc67tUt_Lrt2gw@mail.gmail.com>
2019-04-15 12:08       ` Dongli Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bdc3265-e5a4-e8c8-9098-0bba18a66f19@oracle.com \
    --to=joe.jin@oracle.com \
    --cc=dongli.zhang@oracle.com \
    --cc=haakon.bugge@oracle.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®