From: Jiri Slaby <jirislaby@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jaewon Kim <jaewon02.kim@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCH v3 1/1] tty: serial: samsung: add spin_lock for interrupt and console_write
Date: Thu, 7 Apr 2022 10:05:12 +0200 [thread overview]
Message-ID: <5be92b82-da56-2591-dbf1-fbf63f91c37b@kernel.org> (raw)
In-Reply-To: <6dcddc8a-7ca2-b424-fc8f-7000be3f9116@linaro.org>
On 07. 04. 22, 9:58, Krzysztof Kozlowski wrote:
> On 07/04/2022 09:46, Jiri Slaby wrote:
>> On 07. 04. 22, 9:16, Jaewon Kim wrote:
>>> The console_write and IRQ handler can run concurrently.
>>> Problems may occurs console_write is continuously executed while
>>> the IRQ handler is running.
>>
>> From the patch POV:
>>
>> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
>>
>> But given this is a v3 with no version changelog below "---", you've
>> just kicked the Greg's bot to wake up :P.
>>
>
> There was a cover letter with such changelog:
> https://lore.kernel.org/all/20220407071619.102249-1-jaewon02.kim@samsung.com/
>
> It's indeed easy to miss...
Ah, OK, my bad -- I skipped it as usual -- I don't consider cover
letters that useful. And in this case, even more provided it is for a
single patch.
thanks,
--
js
suse labs
prev parent reply other threads:[~2022-04-07 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220407071223epcas2p2f25428844528dbd505d1b49e0778133d@epcas2p2.samsung.com>
2022-04-07 7:16 ` [PATCH v3 0/1] tty: serial: samsung: add spin_lock in console_write Jaewon Kim
[not found] ` <CGME20220407071223epcas2p16bb11821a0894a3375e84d17c4ff0844@epcas2p1.samsung.com>
2022-04-07 7:16 ` [PATCH v3 1/1] tty: serial: samsung: add spin_lock for interrupt and console_write Jaewon Kim
2022-04-07 7:46 ` Jiri Slaby
2022-04-07 7:58 ` Krzysztof Kozlowski
2022-04-07 8:05 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be92b82-da56-2591-dbf1-fbf63f91c37b@kernel.org \
--to=jirislaby@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon02.kim@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®