From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFADC433E0 for ; Tue, 22 Dec 2020 11:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D23223124 for ; Tue, 22 Dec 2020 11:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726920AbgLVLep (ORCPT ); Tue, 22 Dec 2020 06:34:45 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10057 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgLVLeo (ORCPT ); Tue, 22 Dec 2020 06:34:44 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D0Z2m0WCnzM7yQ; Tue, 22 Dec 2020 19:33:04 +0800 (CST) Received: from [127.0.0.1] (10.40.192.131) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 22 Dec 2020 19:33:53 +0800 Subject: Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() To: Andy Shevchenko CC: Linus Walleij , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List References: <1608539124-4914-1-git-send-email-luojiaxing@huawei.com> From: luojiaxing Message-ID: <5be97c5e-39fc-bf58-aee5-39438948b059@huawei.com> Date: Tue, 22 Dec 2020 19:33:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.40.192.131] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/21 18:35, Andy Shevchenko wrote: > On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing wrote: >> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is >> unused variables. So delete it. > Fixes: tag? Fixes: 356b01a986a5 ("gpio: gpio-hisi: Add HiSilicon GPIO support") Should I send v2 to add this tag? or we can ask linus to help to add it when apply this? Thanks Jiaxing > >> Reported-by: kernel test robot >> Signed-off-by: Luo Jiaxing