From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846EB1802DD for ; Tue, 10 Dec 2024 19:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733860653; cv=none; b=Bhp1ij9zzJR1ukM4kOZ6czeS1y/I3uC7ZOliilRAbBFBbM3ksUbQOWfUf0JmmqTDg0DrhGcaTo1w4UB8PPq5BaI10ibw5Xi+pEh26Em97Qyei73YypQbl5w86Zky2cfwILAXgz/StlzNMbzQ2F96/igympDywtG4LqHNlhlclp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733860653; c=relaxed/simple; bh=mU2dZ3YNjhj40YZyeioCFoEaSTz58aK1GFcWeFnx5tY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dmh814P6wHxlmBm6jtCBDONgfrJ1z0bjdrnKD8oeldS4WL/hyTMzKaKl0GGM2ip0EdcBUkF6spy3xtpVa44xuoqD0E84riV48MET3+pFYFxxqpSvNJRkjKEN3fBG7gUjz3eTToHC+SXybWQtfGfX0+qTVYmyBHiyrPEqjQArH/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G+OYNHtq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G+OYNHtq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733860650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W0st5jf3habWtambXnu8klHlaZXlzS34Gw/nfSI4ntg=; b=G+OYNHtqP0Kn4LZF5Z50VcEpLt0uX7E/84uleJy67t21n/VZZ8M6X5faPRWNwDJ4OK56Xo 3fMImO8HRME2qutQTiyVcuToQB67rXUabdfYQ5FiAEd9augjbHQ5jmcSAm+beJVejjdffW EyMZEAP2IoHgK16GRmMJqVOY4syjcW8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-YpGYE_j2MKi9zmhU0csQIg-1; Tue, 10 Dec 2024 14:57:28 -0500 X-MC-Unique: YpGYE_j2MKi9zmhU0csQIg-1 X-Mimecast-MFC-AGG-ID: YpGYE_j2MKi9zmhU0csQIg Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361b090d23so2348495e9.0 for ; Tue, 10 Dec 2024 11:57:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733860648; x=1734465448; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=W0st5jf3habWtambXnu8klHlaZXlzS34Gw/nfSI4ntg=; b=iqNj9zcghbivxxw53g0zIKPjdz31TLZ3h0WjNVopPumRy4S98e4cS+5f2suEdQX9zV TSUOsSd3oIysQoRna0CjcdMajTZYT3w2OM/Lte5FZVh98dXyuxs1dWFrs0R6Tp51eEYB GaRNgtjcShNoXxKw77SrtvbjuwYgtcCELNuTVQknKajaX7Z971TNc7Yy2Xzl/7DRkebt 8lV/GaLrQlh4MJhvN2nFi/Dnae6EZYuSQ668yHkQYQs5dFnhDSXQcaNypnr2z4P+Kcz9 6tLkAkRzZO5nWlG58hfH233cjhuoxMF4hlpIRXbK4iejMTUg744C7usA3BrxkQy0CNfz he3Q== X-Gm-Message-State: AOJu0Yx/LlqR1Gxu8pqOnSyFoMp+8PJdvIllDxrMh3whoB8gjEoEwpfK cnnrzUeVL9v4IGcXSEKIKMPXhlZ0YBm0LyLIjetU463vDXdtaL46NurNjxdPkAoCV5Hw8t185D2 RENRNU1wT3Om/asY2MhgUdV8mNJheOd2VzmCxdOQsyQPTDPJ/tkURzis9oby2EAO+h49td5/V X-Gm-Gg: ASbGncsSjBWhAZ9HJT/rx51tx1dTdTOy6R7aqvghUNu6Us1L7Y8QD5hBb2mYMhBzlt7 vyVVCq/RCmx6T3r0et5VQ/4Fg3dl69ej7DdgcJ6esV5MXYJedp3Bdjjjj7WhtfzZo+bFMuDFJCW +HimPhsHqWoulhf4D4rOnMxuWsw8FzEIc3yWZSC8WTrzJKyYJmuTWZX6OJBqvA47XfXWXIOB+hW GX1/9KQFfDAkd5YTOCAUAJ2tbsEWiFiMifaReUQkfT9RxWYrHk66/qYp1f25mQeY8z4GIK/2+Y2 BeQcmY0= X-Received: by 2002:a5d:6487:0:b0:385:f349:ffef with SMTP id ffacd0b85a97d-3864ce93b84mr312078f8f.41.1733860647814; Tue, 10 Dec 2024 11:57:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IE93KMavcQiwda+RRG64hyF+A22ttUDRC8aptNtsc3pD5ir23Yw11qhCBhviQt5yBRRgf9QyQ== X-Received: by 2002:a5d:6487:0:b0:385:f349:ffef with SMTP id ffacd0b85a97d-3864ce93b84mr312063f8f.41.1733860647432; Tue, 10 Dec 2024 11:57:27 -0800 (PST) Received: from [192.168.3.141] (p5b0c61ad.dip0.t-ipconnect.de. [91.12.97.173]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-386219096d8sm17011715f8f.78.2024.12.10.11.57.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 11:57:26 -0800 (PST) Message-ID: <5bec0778-3b70-41bb-b1b3-a7559cf88dd4@redhat.com> Date: Tue, 10 Dec 2024 20:57:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Remove problematic include in To: Kevin Brodsky , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, dan.j.williams@intel.com, dave.hansen@linux.intel.com, jane.chu@oracle.com, osalvador@suse.de, tglx@linutronix.de References: <20241210184610.2080727-1-kevin.brodsky@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241210184610.2080727-1-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.12.24 19:46, Kevin Brodsky wrote: > The need for this series arose from a completely unrelated series [1]. > Long story short, that series causes to include > , which doesn't feel too unreasonable. > > That works fine on arm64 and probably most other architectures, but not > on x86 [2]: itself includes , creating a > circular dependency. > > set_memory.h doesn't really need , so removing that include > seems like the right thing to do. That turned out to be a little more > involved than expected, hence this series: > > * Patch 1-2 ensure that code doesn't rely on > including . The errors that these patches fix are included > at the end of this email. > > * Patch 3 removes an unused function whose declaration relied on > being included. > > * Patch 4 actually remove the include. > > I've build-tested this series with x86_64_defconfig and allyesconfig. > > - Kevin > > [1] https://lore.kernel.org/linux-hardening/20241206101110.1646108-1-kevin.brodsky@arm.com/ > [2] https://lore.kernel.org/oe-kbuild-all/202412062006.C23V9ESs-lkp@intel.com/ > > Cc: bp@alien8.de > Cc: dan.j.williams@intel.com > Cc: dave.hansen@linux.intel.com > Cc: david@redhat.com > Cc: jane.chu@oracle.com > Cc: osalvador@suse.de > Cc: tglx@linutronix.de > --- LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb