From: Andy Lutomirski <luto@MIT.EDU>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>, Andy Lutomirski <luto@MIT.EDU>
Subject: [PATCH 2/2] x86: Enable monitor/mwait on Intel if BIOS hasn't already
Date: Wed, 3 Aug 2011 11:47:17 -0400 [thread overview]
Message-ID: <5bec80947da3fb72f2f18fbe6d924a69f83fbed9.1312386029.git.luto@mit.edu> (raw)
In-Reply-To: <cover.1312386029.git.luto@mit.edu>
In-Reply-To: <cover.1312386029.git.luto@mit.edu>
I have a Sandy Bridge machine with an Intel BIOS that enables
monitor/mwait on all but the boot CPU. With this patch, intel_idle
works.
Signed-off-by: Andy Lutomirski <luto@mit.edu>
---
arch/x86/kernel/cpu/intel.c | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 6b20fef..a3339a1 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -487,6 +487,26 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
}
}
+
+ /* Enable monitor/mwait if BIOS didn't do it for us. */
+ if (!cpu_has(c, X86_FEATURE_MWAIT) && cpu_has(c, X86_FEATURE_XMM3)
+ && c->x86 >= 6 && !(c->x86 == 6 && c->x86_model < 0x1c)
+ && !(c->x86 == 0xf && c->x86_model < 3)) {
+ u64 misc_enable;
+ rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable);
+ misc_enable |= MSR_IA32_MISC_ENABLE_MWAIT;
+
+ /*
+ * Some non-SSE3 cpus will #GP. We check for that,
+ * but it can't hurt to be safe.
+ */
+ wrmsr_safe(MSR_IA32_MISC_ENABLE, (u32)misc_enable,
+ (u32)(misc_enable >> 32));
+
+ /* Re-read monitor capability. */
+ if (cpuid_ecx(1) & 0x8)
+ set_cpu_cap(c, X86_FEATURE_MWAIT);
+ }
}
#ifdef CONFIG_X86_32
--
1.7.6
next prev parent reply other threads:[~2011-08-03 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:47 [PATCH 0/2] Forcibly enable some MISC_ENABLE features on Intel Andy Lutomirski
2011-08-03 15:47 ` [PATCH 1/2] x86: Enable fast strings on Intel if BIOS hasn't already Andy Lutomirski
2011-08-03 16:34 ` Yu, Fenghua
2011-08-03 16:39 ` Andrew Lutomirski
2011-08-03 15:47 ` Andy Lutomirski [this message]
2011-08-03 16:15 ` [PATCH 2/2] x86: Enable monitor/mwait " Len Brown
2011-08-03 16:22 ` Andrew Lutomirski
2011-08-03 16:42 ` Andrew Lutomirski
2011-08-03 19:17 ` Len Brown
2011-08-04 3:18 ` Andrew Lutomirski
2011-08-04 19:41 ` Matthew Garrett
2011-08-04 21:54 ` Len Brown
2011-08-04 21:56 ` Matthew Garrett
2011-08-05 9:43 ` Ingo Molnar
2011-08-06 11:42 ` Andrew Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bec80947da3fb72f2f18fbe6d924a69f83fbed9.1312386029.git.luto@mit.edu \
--to=luto@mit.edu \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®