From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Barnabás Czémán" <trabarni@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>, "Andrew Davis" <afd@ti.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: bq256xx: Add omit-battery-class property
Date: Sat, 7 Sep 2024 13:11:57 +0200 [thread overview]
Message-ID: <5bf9a142-05d9-4e02-bca0-f988726e2873@kernel.org> (raw)
In-Reply-To: <20240907-bq256xx-omit-battery-class-v1-1-45f6d8dbd1e5@mainlining.org>
On 07/09/2024 13:07, Barnabás Czémán wrote:
> Add omit-battery-class property for avoid system create a battery device.
This does not help much, basically repeats commit subject. You need to
answer to "why?".
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> index a76afe3ca299..744f5782e8e7 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -62,6 +62,12 @@ properties:
> $ref: /schemas/types.yaml#/definitions/phandle
> description: phandle to the battery node being monitored
>
> + omit-battery-class:
> + type: boolean
> + description: |
> + If this property is set, the operating system does not try to create a
> + battery device.
You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-07 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 11:07 [PATCH 0/2] Add omit-battery-class property for bq256xxx Barnabás Czémán
2024-09-07 11:07 ` [PATCH 1/2] dt-bindings: power: supply: bq256xx: Add omit-battery-class property Barnabás Czémán
2024-09-07 11:11 ` Krzysztof Kozlowski [this message]
2024-09-16 8:48 ` Sebastian Reichel
2024-09-08 8:47 ` Krzysztof Kozlowski
2024-09-07 11:07 ` [PATCH 2/2] power: supply: bq256xx: Add ability to omit battery class Barnabás Czémán
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf9a142-05d9-4e02-bca0-f988726e2873@kernel.org \
--to=krzk@kernel.org \
--cc=afd@ti.com \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=trabarni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®