From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Ryan Chen <ryanchen.aspeed@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andrew Jeffery <andrew@aj.id.au>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles
Date: Sun, 22 Mar 2026 10:51:27 +0100 [thread overview]
Message-ID: <5c00033b-28d4-48f6-811d-6e3b54b8fb10@kernel.org> (raw)
In-Reply-To: <TY2PPF5CB9A1BE63A0E8E056E322866B6F0F24CA@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
On 20/03/2026 09:46, Ryan Chen wrote:
> Hello Krzysztof,
> I review https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/example-schema.yaml?h=v7.0-rc1
> I will do following modify
> - enum:
> - - aspeed,ast2400-sd-controller
> - - aspeed,ast2500-sd-controller
> - - aspeed,ast2600-sd-controller
> + oneOf:
> + - items:
Don't add items here. Was it in original code? No.
> + - enum:
> + - aspeed,ast2400-sd-controller
> + - aspeed,ast2500-sd-controller
> + - aspeed,ast2600-sd-controller
> + - items:
> + - const: aspeed,ast2700-sd-controller
> + - const: aspeed,ast2600-sd-controller
> +
> Thanks the review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-22 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 5:56 [PATCH v2 0/2] Add AST2700 support for aspeed sdhci Ryan Chen
2026-03-17 5:56 ` [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles Ryan Chen
2026-03-18 7:54 ` Krzysztof Kozlowski
2026-03-18 8:09 ` Ryan Chen
2026-03-18 8:16 ` Krzysztof Kozlowski
2026-03-18 8:53 ` Ryan Chen
2026-03-20 8:46 ` Ryan Chen
2026-03-22 9:51 ` Krzysztof Kozlowski [this message]
2026-03-17 5:56 ` [PATCH v2 2/2] mmc: sdhci-of-aspeed: Handle optional controller reset Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c00033b-28d4-48f6-811d-6e3b54b8fb10@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=ryanchen.aspeed@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®