From: Hanjun Guo <guohanjun@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Wang Honghui <honghui.wang@ucas.com.cn>
Cc: Cristian Maruss <cristian.marussi@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Date: Fri, 25 Nov 2022 09:20:28 +0800 [thread overview]
Message-ID: <5c005ae4-bdf2-8d4a-ef3a-c2964c9df5d8@huawei.com> (raw)
In-Reply-To: <20221124111015.vrfuroty4fbemqv7@bogus>
On 2022/11/24 19:10, Sudeep Holla wrote:
> Hi Wang,
>
> On Thu, Nov 24, 2022 at 03:09:31PM +0800, Wang Honghui wrote:
>> arm_scpi: modify to support acpi
>>
>
> 1. The commit message is pretty useless. I don't get the complete picture
> of why you need this change or what you are trying to do in this change.
>
> 2. I am unable to see the series as a whole, just have 2 versions of 3/3
> in my inbox.
>
> 3. This is not the correct way to use SCPI or mailbox in ACPI. You need
> to use PCC and PCC OpRegion to achieve what you want. The whole SCPI
> protocol details gets abstracted in the firmware(ACPI ASL)
Agreed, using PCC for ARM SCPI support, not some self-defined bindings.
If you have any issue to support SCPI in your platform, we can add the
support in the ACPI spec first, but from what I read from the ACPI spec,
the PCC or PCC OpRegion can support SPCI well, let me know if any
issues.
Thanks
Hanjun
prev parent reply other threads:[~2022-11-25 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 7:09 Wang Honghui
2022-11-24 11:03 ` Mark Rutland
2022-11-24 12:23 ` 王洪辉
2022-11-24 13:46 ` Sudeep Holla
2022-11-24 11:10 ` Sudeep Holla
2022-11-25 1:20 ` Hanjun Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c005ae4-bdf2-8d4a-ef3a-c2964c9df5d8@huawei.com \
--to=guohanjun@huawei.com \
--cc=cristian.marussi@arm.com \
--cc=honghui.wang@ucas.com.cn \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®