From: Matthew Sakai <msakai@redhat.com>
To: linux@treblig.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
Date: Thu, 23 May 2024 20:57:53 -0400 [thread overview]
Message-ID: <5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com> (raw)
In-Reply-To: <20240523210716.309324-1-linux@treblig.org>
On 5/23/24 17:07, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'uds_attribute' is unused since
> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Yes, this was clearly an oversight on our part. Feel free to add:
Reviewed-by: Matthew Sakai <msakai@redhat.com>
> ---
> drivers/md/dm-vdo/dedupe.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> index 117266e1b3ae..39ac68614419 100644
> --- a/drivers/md/dm-vdo/dedupe.c
> +++ b/drivers/md/dm-vdo/dedupe.c
> @@ -148,11 +148,6 @@
> #include "vdo.h"
> #include "wait-queue.h"
>
> -struct uds_attribute {
> - struct attribute attr;
> - const char *(*show_string)(struct hash_zones *hash_zones);
> -};
> -
> #define DEDUPE_QUERY_TIMER_IDLE 0
> #define DEDUPE_QUERY_TIMER_RUNNING 1
> #define DEDUPE_QUERY_TIMER_FIRED 2
next prev parent reply other threads:[~2024-05-24 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 21:07 linux
2024-05-24 0:57 ` Matthew Sakai [this message]
2024-05-24 1:09 ` Dr. David Alan Gilbert
2024-05-24 1:34 ` Matthew Sakai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c063045-4bce-14e4-9930-77cc0ed2edad@redhat.com \
--to=msakai@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®