From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E0AC2D0A3 for ; Sat, 24 Oct 2020 15:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAD1C22254 for ; Sat, 24 Oct 2020 15:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761756AbgJXPdu (ORCPT ); Sat, 24 Oct 2020 11:33:50 -0400 Received: from smtprelay0177.hostedemail.com ([216.40.44.177]:47662 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761745AbgJXPdu (ORCPT ); Sat, 24 Oct 2020 11:33:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id A98F918029123; Sat, 24 Oct 2020 15:33:48 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fan26_0d0677727263 X-Filterd-Recvd-Size: 1998 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Sat, 24 Oct 2020 15:33:47 +0000 (UTC) Message-ID: <5c11f284872f3b2b017d9d27d4075582c1a40eab.camel@perches.com> Subject: Re: [PATCH v3] checkpatch: fix false positives in REPEATED_WORD warning From: Joe Perches To: Aditya , Lukas Bulwahn Cc: linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, dwaipayanray1@gmail.com Date: Sat, 24 Oct 2020 08:33:46 -0700 In-Reply-To: References: <20201023133828.19609-1-yashsri421@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote: > > Would you like to work on > > further rules that can be improved with your evaluation approach? > > Yes, I would like work on further rules. Some generic ideas: How about working to reduce runtime and complexity by making the rules extensible or separable at startup. Maybe move each existing rules into a separate directory as an individual file and aggregate them at checkpatch startup. Maybe look at the existing rules that do not have a $fix option and add them as appropriate. You could fix the multiline indentation where the current warning and fix is only for a single line value = function(arg1, arg2, arg3); where checkpatch emits only single warning and fix for the line with arg2, but not the line with arg3); Maybe try to make the coding styles supported more flexible: Allow braces in different places, support different tab indentation sizes, spacing rules around operators, function definition layouts, etc.