From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A597F7F5; Thu, 9 May 2024 20:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715287352; cv=none; b=WMD0bjKrrOjzXZAgIMFB9sgDd2KZdvaWVEqWNG4rH4Y5AzLe/xb1PwB8MzYZfptWuUBli3VxWTdrh0aLIL8tSEV5YXiRHNL+m4CTUCOI1P/63/1TNHVaLWsu3BEfc5+p18eRFkFXJqI5aUTsEfPFk9VDxQNd5mlW8i69KwRaEiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715287352; c=relaxed/simple; bh=NH3S6mWBMlTrXJGDkb8fxqtIov3lrygbiEUtdfVTGrk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ukskxOFO7Qyx8e9xHHGO/aqkUUAPHleYb0Pq3E+e0FvVtCIhTBC7019+v8Gg/1vrXX7YTt7BYaHMMFruak6DdJ3EO+IqsNLWxfhi6YGpabk3s2M8AMnhvwyZsRmVsc00jye/gEAPCvzD1ZmN9RXHzBX3kmzJkOI97HqIFbQPe5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=jYffqosO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="jYffqosO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 449ESocc004043; Thu, 9 May 2024 20:42:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=mchcKYZYgBdbHHHqrwkb0VhG3sZh/TU9UL6kHJgjYIQ=; b=jY ffqosOTwWJOn9DslhDcHQPq/5JBPBHA4oPh+aZw/eCJyhFbRsgvPAgVXRw+G8bXj bkLaOXnafQ6Uz7r5jkXgJV6B4+oDoXj1DFAhs+mA7iKX9noEjXiTXLGW85DdIbU7 atlRJxYT/RwEtR727npiI83gfIHpKAMAdhohDJsapqLdGsQiP61s9+E01zxKWn5w 9nH7UGHaRuTEfN7ZDWKXZ3Lif3BR5+e8vClfhTzfF1udj2x1AEMfdwBz0352JVze YXPO46uFhIRvndMI9ddsW+6L/NYZ1GoOM+3ZeWZPfDAl7ASVumUPuDO3xFi5FB6B 4aE8NDTwGN/5sst38Ong== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3y07u9bu0k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 May 2024 20:42:24 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 449KgMrb001177 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 May 2024 20:42:22 GMT Received: from [10.110.104.129] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 9 May 2024 13:42:21 -0700 Message-ID: <5c15c321-d0b6-847d-3c35-924faffac703@quicinc.com> Date: Thu, 9 May 2024 13:42:20 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] drm/msm/dpu: fix encoder irq wait skip Content-Language: en-US To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter CC: , , , References: <20240509-irq_wait-v2-1-b8b687b22cc4@gmail.com> From: Abhinav Kumar In-Reply-To: <20240509-irq_wait-v2-1-b8b687b22cc4@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: wl7B9Pa7yhoErU9chFnIdSe7wG9GVMWp X-Proofpoint-ORIG-GUID: wl7B9Pa7yhoErU9chFnIdSe7wG9GVMWp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-09_12,2024-05-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405010000 definitions=main-2405090145 On 5/9/2024 12:40 PM, Barnabás Czémán wrote: > The irq_idx is unsigned so it cannot be lower than zero, better > to change the condition to check if it is equal with zero. > It could not cause any issue because a valid irq index starts from one. > > Fixes: 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1") > Signed-off-by: Barnabás Czémán > --- > Changes in v2: > - Add Fixes in commit message. > - Link to v1: https://lore.kernel.org/r/20240509-irq_wait-v1-1-41d653e3784e@gmail.com > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > no functional change, so you could have retained by R-b, but here it is again, Reviewed-by: Abhinav Kumar > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 119f3ea50a7c..cf7d769ab3b9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -428,7 +428,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc, > return -EWOULDBLOCK; > } > > - if (irq_idx < 0) { > + if (irq_idx == 0) { > DRM_DEBUG_KMS("skip irq wait id=%u, callback=%ps\n", > DRMID(phys_enc->parent), func); > return 0; > > --- > base-commit: 704ba27ac55579704ba1289392448b0c66b56258 > change-id: 20240509-irq_wait-49444cea77e2 > > Best regards,