From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A02C433F5 for ; Wed, 6 Apr 2022 15:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236510AbiDFPlJ (ORCPT ); Wed, 6 Apr 2022 11:41:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbiDFPk7 (ORCPT ); Wed, 6 Apr 2022 11:40:59 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA6B57F234 for ; Wed, 6 Apr 2022 06:15:02 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id p8so2180960qvv.5 for ; Wed, 06 Apr 2022 06:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=8N0CvfLws0NLfRseiGnNqJN6eohHipGooNObOqOlBoc=; b=EvQQ/HwBH9nTQj1t5326cVr1a8c+tpiFpSw2vuQcKK4x1e0TX8OBzNpnPZ096XFsrE 0ReG2cE6XRXkl41gyZjT1S/DgUXamBCWr4HVULUDSQM2wWOOPKeRifJ5M6EXG2QzqlZc rW69m0WEf3gxCTxUmY2EuNEMZu9dgd4aWHjmhCZHXdDbhC8OSIdOWbLE64/7BLNiW3X2 kBP2BEgL7y7aFgyN3ebhig0yxbvsPW0+UHATP2UhXGdpweSmVBjQq/HX9htgqGjYbsQg jjAWm0ttcxyAOtfp1LxwQ0cRTv8+AsL2Fx1Y2MQxfqDJ3dvKWOVv0BxVUknTX3MAsC6A 3Ukw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=8N0CvfLws0NLfRseiGnNqJN6eohHipGooNObOqOlBoc=; b=LqWuGpJ2Ie84FJ10rhWOMmJAO7VzRFqZkArkDENG1TODuBPVvAbYhXhwk8BHAb29xv 4G5W73H9xHkQLtAxR7i1PSnVeMsqxZserWvioArDgHrZ/rwXNA3JrvmOoE1bFGkEp8rF UsTTGfTYlTJQZP+k7qF/lSWOZjSFPaXZNHTu6Cfp4QQlRYr8E9l4aSCR611JCcdEeIQC txfyiS6ZsB+Ms5g8AUdHsEYa1vw+ItzpLN57e0OY8cUXiLWIFqcIX+9reY5DNFZotaB4 isM7/fK1mjsOUyPOd32wSQ+MgRQjpUMiGUjO4O2DHLPogihlTt3kbcEUJ7vECF+x2cHt iCUQ== X-Gm-Message-State: AOAM532EKyQMY6PV84O5w7rUn0635RdtaXMHDXtv3ml/2Wyml/Yq8SV8 hu1zoURzcNjxbYif1cBtV8zlpQ== X-Google-Smtp-Source: ABdhPJySaVPBdyzFHzfJKSHKkPd1JA+dpYpBIJIxwqBWJeTCDsXQB8+GyZydfPlDh/ZW4wIZUkA5IQ== X-Received: by 2002:a05:6214:4011:b0:443:e253:61fc with SMTP id kd17-20020a056214401100b00443e25361fcmr6868372qvb.110.1649250896805; Wed, 06 Apr 2022 06:14:56 -0700 (PDT) Received: from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net. [173.246.12.168]) by smtp.gmail.com with ESMTPSA id t67-20020ae9df46000000b006809a144ac1sm10369209qkf.99.2022.04.06.06.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 06:14:56 -0700 (PDT) Message-ID: <5c200bbb0e2d73642115649f05f945840b0ef67a.camel@ndufresne.ca> Subject: Re: [PATCH] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Wed, 06 Apr 2022 09:14:54 -0400 In-Reply-To: <20220406012048.5970-1-yunfei.dong@mediatek.com> References: <20220406012048.5970-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.0 (3.44.0-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 06 avril 2022 =C3=A0 09:20 +0800, Yunfei Dong a =C3=A9crit=C2= =A0: > Will return -EINVAL using standard framework api when test stateless > decoder with cmd VIDIOC_(TRY)DECODER_CMD. >=20 > Using another return value to adjust v4l2 compliance test for user > driver(GStreamer/Chrome) won't use decoder cmd. >=20 > Fixes: 8cdc3794b2e3 ("media: mtk-vcodec: vdec: support stateless API") > Signed-off-by: Yunfei Dong > Reviewed-by: AngeloGioacchino Del Regno Acked-by: Nicolas Dufresne > --- > changes compared with v2: > - add reviewed-by tag > changes compared with v1: > - add Fixes: tag > --- > drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/dr= ivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > index 3859e4c651c6..69b0e797d342 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > @@ -51,8 +51,7 @@ static int vidioc_try_decoder_cmd(struct file *file, vo= id *priv, > =20 > /* Use M2M stateless helper if relevant */ > if (ctx->dev->vdec_pdata->uses_stateless_api) > - return v4l2_m2m_ioctl_stateless_try_decoder_cmd(file, priv, > - cmd); > + return -ENOTTY; > else > return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd); > }