From: Alexei Starovoitov <ast@fb.com>
To: Josef Bacik <josef@toxicpanda.com>, <rostedt@goodmis.org>,
<mingo@redhat.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ast@kernel.org>, <kernel-team@fb.com>, <daniel@iogearbox.net>,
<linux-btrfs@vger.kernel.org>, <darrick.wong@oracle.com>,
<mhiramat@kernel.org>
Cc: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH v10 3/5] bpf: add a bpf_override_function helper
Date: Fri, 15 Dec 2017 12:34:18 -0800 [thread overview]
Message-ID: <5c212496-f898-988c-ea40-4ac6b7168d87@fb.com> (raw)
In-Reply-To: <1513365176-6744-4-git-send-email-josef@toxicpanda.com>
On 12/15/17 11:12 AM, Josef Bacik wrote:
> +#ifdef CONFIG_BPF_KPROBE_OVERRIDE
> +BPF_CALL_2(bpf_override_return, struct pt_regs *, regs, unsigned long, rc)
> +{
> + __this_cpu_write(bpf_kprobe_override, 1);
> + regs_set_return_value(regs, rc);
> + arch_ftrace_kprobe_override_function(regs);
> + return 0;
> +}
since you're doing a respin can you adopt the change I did to make
this helper fail at load time if that #config is not set
instead of runtime?
Also how big is the v9-v10 change ?
May be do it as separate patch, since previous set already sitting
in bpf-next and there are patches on top?
next prev parent reply other threads:[~2017-12-15 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 19:12 [PATCH v10 0/5] Add the ability to do BPF directed error injection Josef Bacik
2017-12-15 19:12 ` [PATCH v10 1/5] add infrastructure for tagging functions as error injectable Josef Bacik
2017-12-18 9:11 ` Masami Hiramatsu
2017-12-19 6:29 ` Masami Hiramatsu
2017-12-20 2:14 ` Alexei Starovoitov
2017-12-20 7:13 ` Masami Hiramatsu
2017-12-20 10:09 ` Daniel Borkmann
2017-12-20 17:22 ` Alexei Starovoitov
2017-12-20 11:00 ` Masami Hiramatsu
2017-12-20 17:33 ` Alexei Starovoitov
2017-12-15 19:12 ` [PATCH v10 2/5] btrfs: make open_ctree " Josef Bacik
2017-12-15 19:12 ` [PATCH v10 3/5] bpf: add a bpf_override_function helper Josef Bacik
2017-12-15 20:34 ` Alexei Starovoitov [this message]
2017-12-15 20:53 ` Daniel Borkmann
2017-12-18 9:51 ` Masami Hiramatsu
2017-12-18 15:09 ` Daniel Borkmann
2017-12-19 6:38 ` Masami Hiramatsu
2017-12-15 19:12 ` [PATCH v10 4/5] samples/bpf: add a test for bpf_override_return Josef Bacik
2017-12-15 19:12 ` [PATCH v10 5/5] btrfs: allow us to inject errors at io_ctl_init Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c212496-f898-988c-ea40-4ac6b7168d87@fb.com \
--to=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®