From: Dan Carpenter <dan.carpenter@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] cifs: make cifs_chan_update_iface() a void function
Date: Tue, 9 Jan 2024 10:39:49 +0300 [thread overview]
Message-ID: <5c29dddd-2952-4993-9347-7bb11bdf2914@moroto.mountain> (raw)
In-Reply-To: <4c6b12c9-0502-400a-b2ba-dad89ef4f652@wanadoo.fr>
On Mon, Jan 08, 2024 at 08:09:17PM +0100, Christophe JAILLET wrote:
> > @@ -478,13 +475,13 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
> > chan_index = cifs_ses_get_chan_index(ses, server);
> > if (chan_index == CIFS_INVAL_CHAN_INDEX) {
> > spin_unlock(&ses->chan_lock);
> > - return 0;
> > + return;
> > }
> > ses->chans[chan_index].iface = iface;
> > spin_unlock(&ses->chan_lock);
> > - return rc;
> > + return;
>
> just remove this one?
>
Doh. Yeah. I'll send a v2 of this tomorrow.
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-09 7:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:07 [PATCH 1/3] cifs: delete unnecessary NULL checks in cifs_chan_update_iface() Dan Carpenter
2024-01-08 9:08 ` [PATCH 2/3] cifs: make cifs_chan_update_iface() a void function Dan Carpenter
2024-01-08 19:09 ` Christophe JAILLET
2024-01-09 4:41 ` Steve French
2024-01-09 7:44 ` Dan Carpenter
2024-01-09 7:39 ` Dan Carpenter [this message]
2024-01-09 4:42 ` Steve French
2024-01-08 9:09 ` [PATCH 3/3] cifs: simplify a check in cifs_chan_update_iface() Dan Carpenter
2024-01-09 0:52 ` [PATCH 1/3] cifs: delete unnecessary NULL checks " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c29dddd-2952-4993-9347-7bb11bdf2914@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pc@manguebit.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®