From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936597AbcIHMev (ORCPT ); Thu, 8 Sep 2016 08:34:51 -0400 Received: from mga06.intel.com ([134.134.136.31]:38728 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932185AbcIHMeu (ORCPT ); Thu, 8 Sep 2016 08:34:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,300,1470726000"; d="scan'208";a="1047299781" Subject: Re: [PATCH V3] perf tools: adding support for address filters To: Mathieu Poirier , acme@kernel.org References: <1473178763-2870-1-git-send-email-mathieu.poirier@linaro.org> Cc: mingo@redhat.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, acme@infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <5c2ce087-d30e-4ab7-3e91-311f1397ebc3@intel.com> Date: Thu, 8 Sep 2016 15:30:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473178763-2870-1-git-send-email-mathieu.poirier@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/16 19:19, Mathieu Poirier wrote: > This patch makes it possible to use the current filter > framework with address filters. That way address filters for > HW tracers such as CoreSight and IntelPT can be communicated > to the kernel drivers. > > CC: Alexander Shishkin > Signed-off-by: Mathieu Poirier > Acked-by: Jiri Olsa > --- > Changes for V3: > - Added Jiri's ack. > - Rebased to v4.8-rc5. > > Changes for V2: > - Rebased to v4.8-rc4. > - Revisited error path. > > --- > tools/perf/util/parse-events.c | 30 +++++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 2eb8b1ed4cc8..1df413fbf7f8 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1760,12 +1760,26 @@ foreach_evsel_in_last_glob(struct perf_evlist *evlist, > static int set_filter(struct perf_evsel *evsel, const void *arg) > { > const char *str = arg; > + bool found = false; > + int nr_addr_filters = 0; > + struct perf_pmu *pmu = NULL; > > - if (evsel == NULL || evsel->attr.type != PERF_TYPE_TRACEPOINT) { > - fprintf(stderr, > - "--filter option should follow a -e tracepoint option\n"); > - return -1; > - } > + if (evsel == NULL) > + goto err; > + > + while ((pmu = perf_pmu__scan(pmu)) != NULL) > + if (pmu->type == evsel->attr.type) { > + found = true; > + break; > + } > + > + if (found) > + perf_pmu__scan_file(pmu, "nr_addr_filters", > + "%d", &nr_addr_filters); > + > + > + if (evsel->attr.type != PERF_TYPE_TRACEPOINT && !nr_addr_filters) > + goto err; > > if (perf_evsel__append_filter(evsel, "&&", str) < 0) { Address filters cannot be joined with "&&" and the parentheses in perf_evsel__append_filter() won't work either. > fprintf(stderr, > @@ -1774,6 +1788,12 @@ static int set_filter(struct perf_evsel *evsel, const void *arg) > } > > return 0; > + > +err: > + fprintf(stderr, > + "--filter option should follow a -e tracepoint or HW tracer option\n"); > + > + return -1; > } > > int parse_filter(const struct option *opt, const char *str, >