From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7BA9378D63 for ; Thu, 2 Apr 2026 23:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174014; cv=none; b=VVtIKFZa4RTIwHN/Y3JE3Bu7xAk7Y19KCtiWd8vPmvj/JcY8AYbajWhzjYaZnWVP77bQIsikwn0K2SGpYlxtIcr7HDKDkXLB+sQbIDUmsTIbXxIdYqUi07d+BdnjAnK48JMQy8IEQPPXQUNphwEtnJ+ZmqWa9lrydatiAobbmjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174014; c=relaxed/simple; bh=Yg4ysDs0Q4kG/t8HXvX3mU2PCk0aq/j6RJ8x7/yv0fA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UGTWmaeg23mzirvxFR0anzYfauJfrPrQf32YU2TYCp5F/2PXdm/5oQ2o7oEzi9+tpg8IfOzlXrN9Cbw9asvZVF1/D3gHseWHzHB/rkgIsKCtYsXJw1ZWcZ/AgbuO2+3pnycmBv9nrUQe89d3K3vI+WD4H/cuBDViq3lplXYsq0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j4/H0b72; arc=none smtp.client-ip=209.85.221.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j4/H0b72" Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-56a9076813bso632479e0c.3 for ; Thu, 02 Apr 2026 16:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775174012; x=1775778812; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SlCm9p0nxRbzkLk1CSJoTc6OlnGjcRCsgMFK0DSaHlw=; b=j4/H0b72uPgqV37NvCYMFyf0ArjHBDAeoSPY9Lk4dipQHTRVuwEjRBE5kRTxSeE+R/ pHrTj2dXhh3mNccmS1t0N+FatACD1MizmMvve+sYg2APMbOr0AavoAQOML3Jkaaxd8aA lNkZmwrGrpQB2UXe+wBqlFdmVwk3wUD4OKU6Xs770jPzuJ2ZED03Pykuxdl1PZHqsF6A FwjEbS7n8K6lvVvcqcSO76wVYVQPl+UgEe6NNR1NBmDRVacae4FvieXCAfv8djIdXSfQ hYUpr0afXqeIdq8BjhipqL4LAKcNCBwV7VEV4qI2XGwis5mF2IjPjp0MdLuwHB4OJbQT MxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775174012; x=1775778812; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SlCm9p0nxRbzkLk1CSJoTc6OlnGjcRCsgMFK0DSaHlw=; b=m9RaxQjxmLtKiUEBqhsLhmckjAfDEZpLOItUi+vY/1023RAN6C8Uo7+g5ZEdAo+pnV RBHIBhyYS/akOwiSNUXeCgnpeibuPi0WhHR7Fq1Kjr53tlquasuvadgUa3C9oiJ+x6Bv rRxdUuoapNk+KIQ/VhuUa+0Z9rRwGZliJsmpVLP/MynJ4x1J+rAvWUnxcxULbk2Hl3MG 4WK/5VCbsaBdPOpUvyW2EmKyyJi1cVMo0aIb9RXj6RZlkcaaZ9neWxOcweEGTm8Q3Rpe IlyjUD9nP7u9jAPJnKwvdxZi4nkKyMRmHO7BDxCypgTav4LdFwWCiNEFrIJtCwWZyMm3 m/0A== X-Forwarded-Encrypted: i=1; AJvYcCWtqYySeXqpAI7l8QkBumG0Eh92JEWSkkXPyMN818fU3YB2d5H+IKPaIheqqVvEKh8KVpD2la01+x4jAIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzUtjz3HzNz6QfJpCLzoFjTXq7g3daTn4md9aZsApGTnfdDDxna lMQ7704sX3KvIQHx1guJBZ+JejnUdKRAldVGkbCkBZe7pfoLuk64IdpR X-Gm-Gg: ATEYQzwZ5EGMYQhXminDw1EVG98TKtLEJDdp/TLR0maGU6Odws9heSDUpdaH0v2UM/c ha+81WpwTn3R0Z8m/LzsLnlRnRvOaT6mU7OlnaNu9A7LLi3pKp+xr6WMRXA7BJ+yYvCM4H2W1fi a4HPS5+hBROvK7El3DY65tf3tqOwfNL0lyWoWSG1S75Aj+0O5bKbLigEcB/4Wt1EhvDkMue/GEM pG1c99yKlG2QW1b38FCoAtzwQi44quRwhiBCl7QdMB1cVbQv+syyG+4YGYY7EXfnft/+iUHf0DN mtkuyBDS+MVJCd1sJrPA6XB0VH27at07hplDUCcqANE/+pXonM8o1+R7krb+TBlArq/YcKb+4iM vRd65bphsvsmurAcmLeUrFymntJ3hviCZxfg2exMTriMGEc596bD9zx8VbHLgSO8AGs0P8KcuoW eo6bLPG3CPf9AxxvTFp3m+hd7DT3uEmo+wo6FP87SHIl08ZdevhKq5rLoTqElbMJ65+ypWyRp/O FJw X-Received: by 2002:a05:6122:7c8:b0:56a:9841:9f81 with SMTP id 71dfb90a1353d-56dab8e9fd0mr363153e0c.6.1775174011637; Thu, 02 Apr 2026 16:53:31 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-217.user3p.v-tal.net.br. [177.4.161.217]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9baff553sm5208171e0c.8.2026.04.02.16.53.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 16:53:31 -0700 (PDT) Message-ID: <5c3505fc-fe80-447b-bd6a-5816fc8c9479@gmail.com> Date: Thu, 2 Apr 2026 20:53:27 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ALSA: hda: Notify IEC958 Default PCM switch state changes To: Takashi Iwai Cc: Takashi Iwai , Jaroslav Kysela , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260402-hda-spdif-share-notify-v2-1-7c6584ecaa21@gmail.com> <87fr5dibu6.wl-tiwai@suse.de> From: =?UTF-8?Q?C=C3=A1ssio_Gabriel_Monteiro_Pires?= Content-Language: en-US In-Reply-To: <87fr5dibu6.wl-tiwai@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/2/26 13:08, Takashi Iwai wrote: > On Thu, 02 Apr 2026 16:45:13 +0200, > Cássio Gabriel wrote: >> >> --- a/sound/hda/common/hda_local.h >> +++ b/sound/hda/common/hda_local.h >> @@ -12,6 +12,8 @@ >> >> #include >> >> +struct snd_kcontrol; > > No need for an extra declaration. > >> + >> /* We abuse kcontrol_new.subdev field to pass the NID corresponding to >> * the given new control. If id.subdev has a bit flag HDA_SUBDEV_NID_FLAG, >> * snd_hda_ctl_add() takes the lower-bit subdev value as a valid NID. >> @@ -203,6 +205,7 @@ enum { HDA_DIG_NONE, HDA_DIG_EXCLUSIVE, HDA_DIG_ANALOG_DUP }; /* dig_out_used */ >> #define HDA_MAX_OUTS 5 >> >> struct hda_multi_out { >> + struct snd_kcontrol *share_spdif_kctl; /* cached shared SPDIF switch */ > > I'd put at the tail of the struct as it's rather an optional stuff. > > > thanks, > > Takashi Thanks, I'll drop the extra declaration and move share_spdif_kctl to the tail for v3. -- Thanks, Cássio