From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Waiman Long <longman@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-arch@vger.kernel.org, "Juergen Gross" <jgross@suse.com>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
x86@kernel.org, kvm@vger.kernel.org,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Pan Xinhui" <xinhui.pan@linux.vnet.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Chris Wright" <chrisw@sous-sol.org>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xenproject.org,
"Alok Kataria" <akataria@vmware.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH v2] x86/paravirt: Don't make vcpu_is_preempted() a callee-save function
Date: Tue, 14 Feb 2017 16:18:55 +0000 [thread overview]
Message-ID: <5c3c2a13-b397-6e9f-8772-a8aaa3f70771@citrix.com> (raw)
In-Reply-To: <fc65322b-902e-6589-f64c-62be5abdb093@redhat.com>
On 14/02/17 14:46, Waiman Long wrote:
> On 02/14/2017 04:39 AM, Peter Zijlstra wrote:
>> On Mon, Feb 13, 2017 at 05:34:01PM -0500, Waiman Long wrote:
>>> It is the address of &steal_time that will exceed the 32-bit limit.
>> That seems extremely unlikely. That would mean we have more than 4G
>> worth of per-cpu variables declared in the kernel.
> I have some doubt about if the compiler is able to properly use
> RIP-relative addressing for this. Anyway, it seems like constraints
> aren't allowed for asm() when not in the function context, at least for
> the the compiler that I am using (4.8.5). So it is a moot point.
You can work the issue of not having parameters in a plain asm()
statement by using an asm-offset, stringizing it, and have C put the
string fragments back together.
"cmpb $0, " STR(STEAL_TIME_preempted) "(%rax);"
~Andrew
next prev parent reply other threads:[~2017-02-14 16:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 15:43 Waiman Long
2017-02-10 16:19 ` Peter Zijlstra
2017-02-10 16:35 ` Waiman Long
2017-02-10 17:00 ` Waiman Long
2017-02-13 10:47 ` Peter Zijlstra
2017-02-13 10:53 ` Peter Zijlstra
2017-02-13 19:42 ` Waiman Long
2017-02-13 20:12 ` Waiman Long
2017-02-13 21:52 ` Peter Zijlstra
2017-02-13 22:00 ` hpa
2017-02-13 22:07 ` hpa
2017-02-13 22:34 ` Waiman Long
2017-02-13 22:36 ` hpa
2017-02-14 9:39 ` Peter Zijlstra
2017-02-14 14:46 ` Waiman Long
2017-02-14 16:03 ` Peter Zijlstra
2017-02-14 16:18 ` Andrew Cooper [this message]
2017-02-13 20:06 ` hpa
2017-02-13 21:57 ` Peter Zijlstra
2017-02-13 22:24 ` Waiman Long
2017-02-13 22:31 ` Peter Zijlstra
2017-02-13 19:41 ` Waiman Long
2017-02-10 16:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3c2a13-b397-6e9f-8772-a8aaa3f70771@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=akataria@vmware.com \
--cc=boris.ostrovsky@oracle.com \
--cc=chrisw@sous-sol.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®