From: "Shenhar, Talel" <talel@amazon.com>
To: Rob Herring <robh@kernel.org>
Cc: <maz@kernel.org>, <mark.rutland@arm.com>, <arnd@arndb.de>,
<bp@alien8.de>, <mchehab@kernel.org>, <james.morse@arm.com>,
<davem@davemloft.net>, <gregkh@linuxfoundation.org>,
<paulmck@linux.ibm.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<dwmw@amazon.co.uk>, <benh@kernel.crashing.org>,
<hhhawa@amazon.com>, <ronenk@amazon.com>, <jonnyc@amazon.com>,
<hanochu@amazon.com>, <amirkl@amazon.com>, <barakw@amazon.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS
Date: Thu, 10 Oct 2019 14:08:00 +0300 [thread overview]
Message-ID: <5c3d9e1b-0549-0609-4b4a-5edc312a3873@amazon.com> (raw)
In-Reply-To: <20191009232927.GA23987@bogus>
Thanks for the review
On 10/10/2019 2:29 AM, Rob Herring wrote:
> On Mon, Oct 07, 2019 at 03:47:14PM +0300, Talel Shenhar wrote:
>> Document Amazon's Annapurna Labs POS SoC binding.
>>
>> Signed-off-by: Talel Shenhar <talel@amazon.com>
>> ---
>> .../bindings/edac/amazon,al-pos-edac.yaml | 40 ++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml
> Please fix errors with 'make dt_binding_check' and resubmit.
>
> Error: Documentation/devicetree/bindings/edac/amazon,al-pos-edac.example.dts:21.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> Hint: You need an include.
Shall add to v6.
By the way, I was not able to see this error by running 'make
dt_binding_check', but looking in to 'make dtbs_check' I was.
next prev parent reply other threads:[~2019-10-10 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 12:47 [PATCH v5 0/2] Amazon's Annapurna Labs POS Driver Talel Shenhar
2019-10-07 12:47 ` [PATCH v5 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS Talel Shenhar
2019-10-09 23:29 ` Rob Herring
2019-10-10 11:08 ` Shenhar, Talel [this message]
2019-10-07 12:47 ` [PATCH v5 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver Talel Shenhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3d9e1b-0549-0609-4b4a-5edc312a3873@amazon.com \
--to=talel@amazon.com \
--cc=amirkl@amazon.com \
--cc=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=robh@kernel.org \
--cc=ronenk@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®