From: "Eva Kurchatova (Virtuozzo)" <eva.kurchatova@virtuozzo.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Alexander Lobakin <alobakin@pm.me>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] udp: let rx-udp-gro-forwarding aggregate under encapsulation
Date: Mon, 26 Oct 2026 14:23:30 +0200 [thread overview]
Message-ID: <5c4918b5-9675-4031-9456-58f6f51c0a13@virtuozzo.com> (raw)
In-Reply-To: <CAF=yD-LZSec9g_0bBgrcQvq2OO1BrxMSRHH=uU7eamCmWcTO_A@mail.gmail.com>
On 10/19/26 21:19, Willem de Bruijn wrote:
> On Sun, Oct 18, 2026 at 12:54 PM Eva Kurchatova (Virtuozzo)
> <eva.kurchatova@virtuozzo.com> wrote:
>>
>> On Wed, 15 Oct 2026 02:56, Willem de Bruijn wrote:
>> > Uses encapsulation in the same network namespace as where the test
>> > runs? If different namespaces, the socket lookup should fail and
>> > thus the behavior be the same as on a host without a tunnel.
>>
>> Different one: the vxlan sat in the init namespace, the test in the
>> ns it creates. The static key is global, though, so the tunnel turns
>> the lookup on everywhere, and the lookup then runs in the test's
>> receiving namespace, where it finds the test's own receiver: a plain
>> socket bound to any address, without UDP_GRO. That is why the check
>> goes from 1 to 10 the moment a tunnel exists anywhere on the host.
> I also don't have a straightforward fix to the test. Maybe just make
> this one optionally SKIP if it fails.
>
> This is the following test in veth.sh, right?
>
> "
> chk_gro() {
> local msg="$1"
> local expected=$2
>
> ip netns exec $BASE$SRC ping -qc 1 $BM_NET_V4$DST >/dev/null
> NSTAT_HISTORY=$STATS ip netns exec $NS_DST nstat -n
>
> printf "%-60s" "$msg"
> ip netns exec $BASE$DST ./udpgso_bench_rx -C 1000 -R 10 &
> local spid=$!
> sleep 0.1
>
> ip netns exec $NS_SRC ./udpgso_bench_tx -4 -s 13000 -S 1300 -M
> 1 -D $BM_NET_V4$DST
> local retc=$?
> wait $spid
> local rets=$?
> "
>
> which gets called both to verify coalsecing and no coalescing
>
> "
> ip netns exec $NS_SRC ethtool -K veth$SRC tx-udp-segmentation off
> chk_gro " - aggregation with TSO off" 10
>
> ...
>
> ip netns exec $NS_SRC ethtool -K veth$SRC tx-udp-segmentation off
> ip netns exec $NS_DST ethtool -K veth$DST rx-udp-gro-forwarding on
> chk_gro " - aggregation with TSO off" 1
> "
>
> The full solution would be to add a third true routing namespace in
> between, which would not have that local socket without -G..
I agree, and withdraw the patch. The lookup behaves as designed, yet the
test asserts it isn't running.
Will follow-up with a fix to the kselftest via the third namespace, with
your Suggested-by.
prev parent reply other threads:[~2026-10-26 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 16:38 Eva Kurchatova
2026-10-12 10:40 ` netdev-bot+sashiko
2026-10-15 2:56 ` Willem de Bruijn
2026-10-18 16:54 ` Eva Kurchatova (Virtuozzo)
2026-10-19 18:19 ` Willem de Bruijn
2026-10-26 12:23 ` Eva Kurchatova (Virtuozzo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4918b5-9675-4031-9456-58f6f51c0a13@virtuozzo.com \
--to=eva.kurchatova@virtuozzo.com \
--cc=alobakin@pm.me \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®