Re: partial reiser4 review comments

["Nate Diller" <nate.diller@gmail.com>]

On 8/9/06, Hans Reiser <reiser@namesys.com> wrote:
> Christoph Hellwig wrote:
>
> > I must admit that standalone code snipplet doesn't really tell me a lot.
> >
> >Do you mean the possibility to pass around a filesystem-defined structure
> >to multiple allocator calls?  I'm pretty sure can add that, I though it
> >would be useful multiple times in the past but always found ways around
> >it.
> >
> >
> >
> Assuming I understand your discussion, I see two ways to go, one is to
> pass around fs specific state and continue to call into the FS many
> times, and the other is to instead provide the fs with helper functions
> that accomplish readahead calculation, page allocation, etc., and let
> the FS keep its state naturally without having to preserve it in some fs
> defined structure.  The second approach would be cleaner code design,
> that would also ease cross-os porting of filesystems, in my view.

the second approach is the one i was heading towards with my
unfinished a_ops patches.  *please* won't someone pay me to do that
work...

NATE