From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751650AbdITRSn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Sep 2017 13:18:43 -0400
Received: from mout.web.de ([212.227.15.4]:51558 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751307AbdITRSk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Sep 2017 13:18:40 -0400
Subject: Re: [media] Siano: Use common error handling code in
 smsusb_init_device()
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <be0003e5-d8e0-bff6-2205-7e88270ba2b4@users.sourceforge.net>
 <20170920135605.sneukaioeabalkud@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <5c4e91c6-80fd-e17a-d165-b8d4a5e5ce14@users.sourceforge.net>
Date: Wed, 20 Sep 2017 19:18:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170920135605.sneukaioeabalkud@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:WUMXZw3RMKA7HMx7QGT9PJpq4C+UXvA1LzWLYsCVceyH439ypnD
 Ptsokui3wGlrEY9Sceh7du220acQjpBrDApDIk/e5BJLEVbB7x2UTMTniaMB9rY0NiQCSDc
 rtWQVfdpPbBUz1oS+WxjmJnySIrFqlE/1ZT8aLSuOfQgJwx7/f8dLNwJDuqgziHwDGwBmYY
 MY5cE3AQL0P7S9O6GmPbg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2JhSC2JAEgw=:ZzWaAzyI4bHjdB9mHYQTrq
 7DeI8PjXNk2WzS5ZeHX10Akwx7XcpCZpMRzft86dfgpWCutUS0T794cxXJEtkh/UqDhdrwgwI
 11eDTLAFMmdmAY6jYVhEqoJxRrHHpfWn9noMeER7P1ioeEYbsYn1tYeOKwjWW6qsRg/xctRcs
 gk5H/AoD3bgXlzjaQ9h1xw0wX2ZnykKlzhLJyh54oX1mzJVFyYrmE0hsTTJ34epi0XJiIAbzy
 gC4PbKq1qMgb8tIh3DEcSQXkG82MLGpIyAsyUO7IaD3MwITzp9Zs+7LJ8bqrZOIpPma2XoEXm
 JjWTJD+Af6Ex0uuVzhQLMg7fUlam0/MtWfF2G7yXq9mG8AV4+D4wwbBHoB9y1JhGASHnOpo4b
 xHDAwyQt5+UW9OBFPedowq3xD7rU6jWB/AuejF6REFJyi1Pag8/+6VW7IIFb5ACoHRKknMj4t
 eqekZ97P+gL9fVJ2MrbncHZ3FOL+IvQ4A0w9SFgrCFtFQzBMIaLWivQj6kkRMDSEmVH4unXNu
 hJtBF//7hdXfKJIRtyNKGS3wdyKhAgtVNb93Rt2dGK81QYW377OUy/SE3+FenQh3q+xlqk1Fe
 bMxOAWMg1rtWyvkcwcxILGEYo7AEMEi5JhZzXTZqGEQW6ecgRSAnVQvh26IpLjysVD9O2GqIK
 YaZ00/3zfkHrmwNmvIGIgvzcZAx/ZPGutoTyHiM1JHhEaVEV9yDpkr1Jy+kXTB9fJp1GrbeyO
 EFTY/IZzKbJRUkwPt1ftAaETA+56MOI4ru25AgK18WWGL3UsZEEXcIxC0B3NkBDhVnWdoOrMc
 S2RzZIxZlx1Qor8i4/jFDJc7DEdWJcQlu/srIHe8i7Od+iDa4g=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> If smscore_register_device() succeeds then mdev is freed when we call
> smsusb_term_device(intf);  The call tree is:

Thanks for your constructive information.


How do you think about another implementation detail in this function then?

May the statement “kfree(mdev);” be executed before “smsusb_term_device(intf);”
in one if branch?

Regards,
Markus