From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754217AbdBASa4 (ORCPT ); Wed, 1 Feb 2017 13:30:56 -0500 Received: from mail-pg0-f46.google.com ([74.125.83.46]:34537 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbdBASay (ORCPT ); Wed, 1 Feb 2017 13:30:54 -0500 Subject: Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver To: Gwendal Grignou , bleung@chromium.org References: <20170130234722.9692-1-gwendal@chromium.org> Cc: linux-kernel@vger.kernel.org From: Benson Leung Organization: Google Message-ID: <5c512d42-afd0-529d-a26d-10e18f20c173@google.com> Date: Wed, 1 Feb 2017 10:30:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170130234722.9692-1-gwendal@chromium.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JbqKJP9UdQD8rHOJHxmCRnBnGJInuaCb2" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JbqKJP9UdQD8rHOJHxmCRnBnGJInuaCb2 Content-Type: multipart/mixed; boundary="LrEarGJoswPekStOCvuS13IIHLPakL5wX"; protected-headers="v1" From: Benson Leung To: Gwendal Grignou , bleung@chromium.org Cc: linux-kernel@vger.kernel.org Message-ID: <5c512d42-afd0-529d-a26d-10e18f20c173@google.com> Subject: Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver References: <20170130234722.9692-1-gwendal@chromium.org> In-Reply-To: <20170130234722.9692-1-gwendal@chromium.org> --LrEarGJoswPekStOCvuS13IIHLPakL5wX Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Thanks Gwendal for adding the resume handling. Glad to have been able to catch that early. On 01/30/2017 03:47 PM, Gwendal Grignou wrote: > Add a kernel driver for GOOG0006, an ACPI driver reporting an event whe= n > the tablet switch status changes. >=20 > On an ACPI based convertible chromebook check evtest display tablet mod= e > switch changes: > Available devices: > .. > /dev/input/event3: Tablet Mode Switch > .. > Testing ... (interrupt to exit) > Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),= > value 1 > Event: time 1484879712.604360, -------------- SYN_REPORT ------------ > Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),= > value 0 > Event: time 1484879715.132228, -------------- SYN_REPORT ------------ > ... > Check state is updated at resume time when different from suspend time.= >=20 > Signed-off-by: Gwendal Grignou Acked-by: Benson Leung New driver looks good to me. I'll add this to my tree, once I get it up and running. --=20 Benson Leung Senior Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --LrEarGJoswPekStOCvuS13IIHLPakL5wX-- --JbqKJP9UdQD8rHOJHxmCRnBnGJInuaCb2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJYkilaAAoJEB8J9XsKL+ZYRoIP+wfdmb8JJyfmLhiwEAMK7Fdg QUlb2S+ktTgsDOLzQ3z+f2L1TSSmhCWiEiK2Md1X4VM42m5dAD9eVQmnd6py5k0M OCKgQZuGhAgaemPyGhKnoXZieXjbq4/nvT0wFBdyzZRGgiwNqs66IP21n2Vgahcl sXCSC8tBii+L9lOvnX+RQq2dwTI8jajhF3gErdqFLDeN/IGbmo0Wd7vs7B1nIf5R iSh0Wda+F30MWGCNpzUEuxh3UvoSGVjfCrmNLjRkbB9GNy7I0INOh+IidNBZ1l45 K/hkiVCiHZuqr/TZIEDuffPpzZ518uCfB7LXLHlBeWlSJpRkrHwD58v8PQGozWUt RJ5nR3gHwjSryHabUnkQ+lIuETe/bF8nQAUBpqFL9oW8JzOnDU+eCCFe7LxSk08V GT+XG2I1ravGxcAmRwW7bgYs8seLj+bBZKYBuQrC58qd1OJk/1RukejMuOcLGXY/ JtXGZdEf5RRBB8ZpWw2GKuH7IpQf3qwdiUUOOyKeTC50LuN4oVmJLRdsdWSfpzkK JAXwEg5loG4ze8U90U85C5khlrQ1CMHk50UqyuCVxbMjc9SHPIus7CXKsqKXQV1u 0QoC5sQKSb8psGm3F7r5Y6kks2ua2eG3AGwgFscUXsq6PR5dPpw71KsBON4190NB QkxclyCpM2k3RdY9n4Yi =3Hel -----END PGP SIGNATURE----- --JbqKJP9UdQD8rHOJHxmCRnBnGJInuaCb2--