From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbcGRMIg (ORCPT ); Mon, 18 Jul 2016 08:08:36 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55438 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbcGRMIe (ORCPT ); Mon, 18 Jul 2016 08:08:34 -0400 Subject: Re: [PATCH 0/7] dmaengine:omap-dma: Linked List transfer for slave_sg To: Russell King - ARM Linux References: <20160714124242.7579-1-peter.ujfalusi@ti.com> <20160718103137.GG5783@n2100.arm.linux.org.uk> CC: , , , , , From: Peter Ujfalusi Message-ID: <5c538963-ae46-54fc-27bf-dbae81443215@ti.com> Date: Mon, 18 Jul 2016 15:07:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160718103137.GG5783@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/16 13:31, Russell King - ARM Linux wrote: > On Thu, Jul 14, 2016 at 03:42:35PM +0300, Peter Ujfalusi wrote: >> Hi, >> >> The following series with the final patch will add support for sDMA Linked List >> transfer support. >> Linked List is supported by sDMA in OMAP3630+ (OMAP4/5, dra7 family). >> If the descriptor load feature is present we can create the descriptors for each >> SG beforehand and let sDMA to walk them through. >> This way the number of sDMA interrupts the kernel need to handle will drop >> dramatically. > > I suggested this a few years ago, and I was told by TI that there was > no interest to implement this feature as it had very little performance > effect. I can not comment on this... Few years ago I was not involved with the DMA drivers so I don't have any idea why would anyone object to have the linked list (or descriptor load) mode in use whenever it is possible. I was not even aware of the linked list mode of sDMA 3 weeks back, but while reading the TRM - for the interleaved mode mainly it sounded like a good idea to implement this. Not really sure about the raw performance impact, but for interactivity it does help. I remember running 'emerge --sync' on BeagleBoard was pain as it took hours and the board was mostly unusable during that time. With the linked list mode the same takes reasonable time and I can still poke around in the board. > Do I take it that TI have changed their position on this feature? I was not aware of any position on this from TI - as I mentioned I was not involved with DMA. It could be that the position from 'TI' is still what it was. Or changed. But as I have been asked to look after TI DMA drivers upstream and I believe that the linked list mode is a good thing to have - which is backed by my experiences. My position is that linked list support is cool. -- Péter