From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31957C43334 for ; Fri, 22 Jul 2022 11:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232715AbiGVLtx (ORCPT ); Fri, 22 Jul 2022 07:49:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiGVLtw (ORCPT ); Fri, 22 Jul 2022 07:49:52 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28E0B9A05; Fri, 22 Jul 2022 04:49:49 -0700 (PDT) Received: from [192.168.2.145] (109-252-119-232.nat.spd-mgts.ru [109.252.119.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8E91B6601ABD; Fri, 22 Jul 2022 12:49:46 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658490587; bh=MqYe4u+ECqLUduFF9nwMt5GMNViDvgSNcNPt7s7OdOg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=IlVzO74uGYOg3STIPTgPoK/ufASUrLboQfexLEzLvhl4nkY3ynwbYX3zEiUuttlXX QjVJ4xVw5BkkKQSg0DMuSsWKaTER4UyzIsji3cESZTVVw3nHr4zI0RmVpvDdBj7QQ0 /KdakXVjs3EE+a8ossr2CuDP1voSOhE/IL2bLcgrvjRwQZsQAmMdtbYhm1W1oE1uVJ KNT56XW/UqsUv05jE+NKlVv0yDIUI/CnC5hYIYjfDLIuxCr83HFUpuYLBWWpYfS33r H3se/b0lR0RJtJ6QlU5lwvfd1yXQEIm7qMKqRv/WuHiAY8EuPUr0/VWvFNPMroAEqU U60inhtdqnXkA== Message-ID: <5c560ee2-c586-fd3e-c57c-d58825e1a73e@collabora.com> Date: Fri, 22 Jul 2022 14:49:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v8 0/2] DRM GEM fixes Content-Language: en-US From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Emil Velikov , =?UTF-8?Q?Christian_K=c3=b6nig?= , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , linux-tegra@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org References: <20220701090240.1896131-1-dmitry.osipenko@collabora.com> In-Reply-To: <20220701090240.1896131-1-dmitry.osipenko@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/1/22 12:02, Dmitry Osipenko wrote: > This patchset fixes two problems in the common GEM code. First fixed problem > is the bogus lockdep splat that complicates debugging of DRM drivers. Second > problem is the inconsistency in behaviour and improper handling of mapping > the imported GEMs by some drivers, to fix it we will prohibit to map the > imported GEMs like majority of drivers already do. > > Changelog: > > v8: - Dropped stable tag from the "Don't map imported GEMs" patch, > like was suggested by Thomas Hellström in the review comment to v7. > > v7: - Factored out GEM patches from [1] since I'll be working on the > dma-buf locking in a separate patchset now. > > [1] https://lore.kernel.org/all/20220526235040.678984-1-dmitry.osipenko@collabora.com/ > > - Improved commit message and added fixes tag to the "Properly annotate > WW context" patch. > > - Replaced "Move mapping of imported dma-bufs to drm_gem_mmap_obj()" > patch with "Don't map imported GEMs", like was suggested by > Thomas Hellström. > > - Added r-b and suggested-by from Thomas Hellström. > > Dmitry Osipenko (2): > drm/gem: Properly annotate WW context on drm_gem_lock_reservations() > error > drm/gem: Don't map imported GEMs > > drivers/gpu/drm/drm_gem.c | 8 ++++++-- > drivers/gpu/drm/drm_gem_shmem_helper.c | 9 --------- > 2 files changed, 6 insertions(+), 11 deletions(-) > Could anyone please take this into drm-misc-next? Maybe Thomas? Thanks in advance -- Best regards, Dmitry