From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0A4C07E9B for ; Wed, 21 Jul 2021 04:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DD8D611C1 for ; Wed, 21 Jul 2021 04:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232549AbhGUERD (ORCPT ); Wed, 21 Jul 2021 00:17:03 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:45728 "EHLO mail-ed1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbhGUEQe (ORCPT ); Wed, 21 Jul 2021 00:16:34 -0400 Received: by mail-ed1-f49.google.com with SMTP id x17so747539edd.12; Tue, 20 Jul 2021 21:57:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G1CpyrlxbkQi8C3eKrGFY5ZV8sAO1WbnuAPLS/w9iyc=; b=jBAPrGNXTUYVryYWhW0yT82PbMHi6faQKRsQBZ69QIjwFn9LHNNOKiwdpXDgP8eODT mcjqoYgQVqE+/u2QizmTlciVzQ8XxSXZCQhaeMxhz0OVoU/CO8hro5tDPyt5buhTgBBr 6D79fsPpebjzEq+fElrM5fuOBHPrfoJWU+lMHYl4vSsjG+Rq9/LJsDMeC47jozKdCksK MpfWnuK60gJsgIXBRWBVj/YVlx+VR3ZEUxX00Tl2Aq9gtvEAe+9lBlAhXm0+vOVxe/Xz la8a+ectMxcWTj2nGpGNVq1BVW2ICDFn0qnDPCv7AqIhncIffoIROj1JWooEUGN5M4v4 s/vw== X-Gm-Message-State: AOAM530kArH/FdYWpIgzF5A83swCItLPHIOntOwM4p+KN2cA88y/oJzO B+8Vnx7gJyJRzWlAodWS3pD0yToTnTkuYxn+ X-Google-Smtp-Source: ABdhPJxO2gHuT5k9dcnnZGNk0MGMbiLxVmvaik28q18dCpokHnuwiZzoDtkaMJ2BA5ylmY0hCGjwCw== X-Received: by 2002:aa7:c4c7:: with SMTP id p7mr45104066edr.290.1626843430294; Tue, 20 Jul 2021 21:57:10 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id s18sm7979195ejh.12.2021.07.20.21.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 21:57:09 -0700 (PDT) Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver To: Long Li , "longli@linuxonhyperv.com" , "linux-fs@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" Cc: Jonathan Corbet , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Greg Kroah-Hartman , Bjorn Andersson , Hans de Goede , "Williams, Dan J" , Maximilian Luz , Mike Rapoport , Ben Widawsky , Andra Paraschiv , Siddharth Gupta , Hannes Reinecke , "linux-doc@vger.kernel.org" References: <1626751866-15765-1-git-send-email-longli@linuxonhyperv.com> <1626751866-15765-3-git-send-email-longli@linuxonhyperv.com> <90ed52d3-5095-9789-53f0-477ba70edc3b@kernel.org> From: Jiri Slaby Message-ID: <5c5dd1e5-2639-b293-b2e0-d7cfd5ca3c0c@kernel.org> Date: Wed, 21 Jul 2021 06:57:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 07. 21, 0:12, Long Li wrote: >> Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver >> >> On 20. 07. 21, 5:31, longli@linuxonhyperv.com wrote: >>> --- /dev/null >>> +++ b/include/uapi/misc/hv_azure_blob.h >>> @@ -0,0 +1,34 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ >>> +/* Copyright (c) 2021 Microsoft Corporation. */ >>> + >>> +#ifndef _AZ_BLOB_H >>> +#define _AZ_BLOB_H >>> + >>> +#include >>> +#include >> >> Quoting from >> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore. >> kernel.org%2Flinux- >> doc%2FMWHPR21MB159375586D810EC5DCB66AF0D7039%40MWHPR21MB1 >> 593.namprd21.prod.outlook.com%2F&data=04%7C01%7Clongli%40micr >> osoft.com%7C7fdf2d6ed15d4d4122a308d94b6eeed0%7C72f988bf86f141af91 >> ab2d7cd011db47%7C1%7C0%7C637623762292949381%7CUnknown%7CTWFp >> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC >> I6Mn0%3D%7C3000&sdata=kv0ZkU1QL6TxlJJZEQEsT7aqLFL9lmP2SStz8k >> U5sIs%3D&reserved=0: >> ===== >> Seems like a #include of asm/ioctl.h (or something similar) is needed so that >> _IOWR is defined. Also, a #include is needed for __u32, __aligned_u64, >> guid_t, etc. >> ===== > > The user-space code includes "sys/ioctl.h" for calling into ioctl(). "sys/ioctl.h" > includes , so it has no problem finding _IOWR. > > guid_t is defined in , included from (in this file) > __u32 and __aligned_u64 are defined in , which is included from (in this file) No, please don't rely on implicit include chains. Nor that userspace solves the includes for you. thanks, -- js suse labs