From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2532ACA9EA0 for ; Tue, 22 Oct 2019 15:53:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06174214B2 for ; Tue, 22 Oct 2019 15:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388777AbfJVPxb (ORCPT ); Tue, 22 Oct 2019 11:53:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387888AbfJVPxb (ORCPT ); Tue, 22 Oct 2019 11:53:31 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AFC583F42 for ; Tue, 22 Oct 2019 15:53:30 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id 92so4034976wro.14 for ; Tue, 22 Oct 2019 08:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JG+rDaiZPjv/G30aIXSiabMNCIhXTu4D3139P64uM1U=; b=IhKzwdBC4Rwrx3od6zl4oKzYzwgJhp5XCnJDp/Zz4IPw1NTa6ItVTmCOZufAXg8GgI Xf6D3WYjiBuB0lR0T9gpm1LDN18fCTBQjBrUcmC6FsJwiIkRNNC1PqFE9DFKzDdY1ZSX Gq2oylgnQKV5/EQaL4AKrZolhgZ3A9JE3TEkQn+bu6/Nb81Lqe/iD7RT4buUHUCMpcbT DjDMZP6OnHKwyV+H7UZcK/bPuX+9RRgZu4fFX5Z7OhTM/G180a09DO5fCEzw3Eiv/Ab6 uKOl1pD8xQZmixvRlPK8bvIwtRDLh9kQigOYO/FpFYlnTdJAwsQxgoJeStUL1ZVrroEH v4cw== X-Gm-Message-State: APjAAAX3hpwsmH8GhY6IsyApWCl0rDfxBEacNrY37Z4dENeNs2qEpYER 7ROOji84x52qiPakL7DAzg4ZUAKetjr1T/9hNPWqsn6cF3e92li+3vLXIQ92tgzGEk+AGG4jlP7 2EiiqvLGvMLoCTeEr2OEGb2nj X-Received: by 2002:a1c:c90c:: with SMTP id f12mr3515222wmb.97.1571759608919; Tue, 22 Oct 2019 08:53:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6V+VvQ3ZIcj/uWsxd5zvt1LhKvigbB1GL0YOeGKZ2oispvsSJTapzUQJ7s70S4Bt0HGQCSQ== X-Received: by 2002:a1c:c90c:: with SMTP id f12mr3515188wmb.97.1571759608659; Tue, 22 Oct 2019 08:53:28 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c0e4:dcf4:b543:ce19? ([2001:b07:6468:f312:c0e4:dcf4:b543:ce19]) by smtp.gmail.com with ESMTPSA id t123sm24286579wma.40.2019.10.22.08.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 08:53:28 -0700 (PDT) Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots To: Sean Christopherson Cc: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Marc Zyngier , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org References: <20191022003537.13013-1-sean.j.christopherson@intel.com> <20191022003537.13013-15-sean.j.christopherson@intel.com> <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> <20191022152827.GC2343@linux.intel.com> <625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com> <20191022155220.GD2343@linux.intel.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <5c61c094-ee32-4dcf-b3ae-092eba0159c5@redhat.com> Date: Tue, 22 Oct 2019 17:53:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191022155220.GD2343@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/10/19 17:52, Sean Christopherson wrote: > > Anyways, I'm not at all opposed to adding comments, just want to make sure > I'm not forgetting something. If it's ok with you, I'll comment the code > and/or functions and reply here to refine them without having to respin > the whole series. Yes, I agree this is better. Paolo