From: linmiaohe <linmiaohe@huawei.com>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: "adobriyan@gmail.com" <adobriyan@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"cyphar@cyphar.com" <cyphar@cyphar.com>,
"christian@brauner.io" <christian@brauner.io>,
Mingfangsen <mingfangsen@huawei.com>,
"mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] proc:fix confusing macro arg name
Date: Tue, 8 Oct 2019 08:28:51 +0000 [thread overview]
Message-ID: <5c66196346aa47d7a252a8c0dd67ae84@huawei.com> (raw)
On 2019/10/8 15:05, Aubrey wrote:
>> On 2019/10/8 14:44, linmiaohe wrote:
>> state_size and ops are in the wrong position, fix it.
>>
>
> Good catch!
>
> This is interesting, I saw this interface has 50+ callers, How did they work before? ;)
>
This confused me too. The args of function proc_create_net_single is consistent with
the callers, so it works. But the wrong args name in macro proc_create_net makes
it confusing.
Thanks, have a nice day!
> Thanks,
> -Aubrey
>
next reply other threads:[~2019-10-08 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:28 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-08 6:44 linmiaohe
2019-10-08 7:04 ` Li, Aubrey
2019-10-08 7:27 ` Aleksa Sarai
2019-10-08 11:22 ` Christian Brauner
2019-09-10 2:17 Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c66196346aa47d7a252a8c0dd67ae84@huawei.com \
--to=linmiaohe@huawei.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aubrey.li@linux.intel.com \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=mm-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome