From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C39C8F48 for ; Thu, 25 Dec 2025 02:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766631479; cv=none; b=aEqCyhZBzXyq2vYmqV3Ld1Q4TGOp3txoSEY18/iPa1yZHET7DBi1Lm4BSLyXJF9fm1yNaJJNvijA7R0wTx4YGYEx7zUV8fponw7x9z0D7Zk8M1quuK3tDUywsi4OQJwUXiI5f+E6eP72IB7E8Se5Y9wFPo/ogBu0ABkntTvmjz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766631479; c=relaxed/simple; bh=lJ6ueQEYA3aIXEVospwgPiFJXldWtXFjf0BwnwOtHD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=McuPU5AIc9SGjsL06bs8DLCB3OAeGKLjUuhJm+OJKCXrRa5F9NnnRBkim3nKTqJAYYeEPoBFtdB9pCvWCsiIQOEVkStsUdPe4OMRfekESBHzMB/08hDUf4DtwtSBg5CtJZjlAxXpCOxEsZ8ctfW0O22XAkDOPlR4Ey2yVkHtkDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=igQhehDd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BdfTcNBB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="igQhehDd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BdfTcNBB" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BONrFsK750431 for ; Thu, 25 Dec 2025 02:57:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JFPd58wm8mYS/zmIQEJmpXYiwDFADj86sZNP3r9GaCg=; b=igQhehDdGSSON/N/ vllBXNcIvUCNMvNUHJENXu1zcBzVMZSJbgr8ccXJqGo2nK2jfXXmwiEKR5wNIsKc ripR3ysblcrQ8RLdKzQebhMK7cUm3hqfJI2nXt4OL5Ot9QWuNuMnnii0jM90qGV9 DgX6Xh4/kCiyFbz+fe2c4J+vL3okVVfPU32ucGmU29ihuTpdzt7ZPc2ZiAiH4m3a qoj2qIuSg9rlY6QUNFKMUGpI0lXA0QrlFkSfSumPj8Ng7PYrBmuF/1iax6FzuJ+g +z2cXYiX74JW8Z33LrNT/OO0k7B3Vbdg4wM+ufRz7jXwPgsfu2+rh6egvMzaIzY6 MKu8pg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8kywgrp0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Dec 2025 02:57:54 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c37b8dc4fso13503641a91.2 for ; Wed, 24 Dec 2025 18:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766631474; x=1767236274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JFPd58wm8mYS/zmIQEJmpXYiwDFADj86sZNP3r9GaCg=; b=BdfTcNBBXbF1yxSM82ad/eRnXUOnSUeRM4PQtYIjjJt3U4jtTAsT2GLGc8RavmpSZg movTHH50cQGgY/bFSv6lwP0Qu2nR1IeeIXwSVgR9cd/pJiZeQwnt91uxdkB9PKgdbekD 5UuugCassUvQ5XYJL6MKQsknLU4YlJBpRvtG0DRmRifn/xkbFpJfddOUALF2MT1i6h1T g9rlHUG5qW5ewMZT8EMvO++eaM3n1ts3rNaKJTwqQDls2sDuzW+ae9vOtkEszwbFqMgl OZI9TC5+ZXsymCJ1c4t3j5ve7SdaaIiSxkKk0vZaTt/LFWnG3p3xDsfAag8dkRrKVQUs fqzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766631474; x=1767236274; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JFPd58wm8mYS/zmIQEJmpXYiwDFADj86sZNP3r9GaCg=; b=vcvQBMepZxA6i7t3Plgu6P5spa7FGdIkHGbkY7kidb204rp1lI4j5t+aALfm5Tmymq mnY83H6+SIy7QdRWbIRH8DrSC8gl4/E1pNPP6+agb6q8AaNcKNKPwC9yBE7950Ka0fup crOCP2IvnyZlXvLY5Hox24aQ5fAskrs+2xpJBKjYzGdnQN9siKRySNMvkmQc1zlQSSfh 5W4AEYEij/KnRxWhmn6lYT5WsCBm0h5YbyZex6a1/CTerso2ZKLc2k+rvQromIAiWkZm nFCt5/PrIia/EcIQoWWHalF0erUmCtRB2b0WWwQYfnWUmhrvqTOhVTcTZNipl7aDSv1H 5mHA== X-Gm-Message-State: AOJu0Yzg9OL0NnPbDwH5GZdjPWJePPgvhQTqqTPVQnTr2tzGMUzthLSy EK2eQEdPqJAzCrZ7YAZEqT75SyCDlFhw7THaM3N27J9hV4izo10hRXRnYUw807u+YJHkWHjsnhh VAAfQkhU50P2BNuGg5UCZEDt1gGvgZ2XXFxAmrrbXE8p1kWNFGpfnUOy8Ac+yvTP4jTc= X-Gm-Gg: AY/fxX58KzKPSrTmJUbo206SXuSeCE/MdKbNMQsfkVHJ8mCnHPwAcD/YAp1QNRGzu9u YirD9Qlz/cefwFgGYzmmAHEJqnxXKbOi/X6yAIOtZ6leA2h7zfUpBro8LNgt+gO3J/wOeKAgJr9 v3SG/3/31MXW6B0hnDs6Nb1Yg8uacWlNECsaakXPGiHKmwPFSveUD0Ogoyr61nPG4uQyzzUODWJ hCHhcTDE6PsK3XpcRJyZxUwrBk2hAz38EnSPFLac1ZmNYgR6UTtpFhumygYGJEvKFIxUhzMQFp/ KBsLdesUGnfZMkbv0bdHSQxULII/BMGqfiB6SlUKVYpOsbIWHPfl4rxw6CuKwakKkK99rrgwMyK AuwP0g8vf8JANiQXdZhofVVUkGk0rjnf09IVwF7IYcMzpkXo87jJcSPK0Il/DdNzFyWsl8EVSuV A= X-Received: by 2002:a17:90b:4d8c:b0:34c:904a:d92 with SMTP id 98e67ed59e1d1-34e921cc22emr18964662a91.26.1766631473560; Wed, 24 Dec 2025 18:57:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLS4MIGJ0LuIKRIK72qiNNG01ippH6Yq5aw5IQOoDuFbYRE35g705XC+ROfIHK9ZC5xSBxaw== X-Received: by 2002:a17:90b:4d8c:b0:34c:904a:d92 with SMTP id 98e67ed59e1d1-34e921cc22emr18964646a91.26.1766631472999; Wed, 24 Dec 2025 18:57:52 -0800 (PST) Received: from [10.133.33.250] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34ed530475bsm3298572a91.8.2025.12.24.18.57.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 18:57:52 -0800 (PST) Message-ID: <5c67a270-dc9e-4ada-af56-e97d4a925e47@oss.qualcomm.com> Date: Thu, 25 Dec 2025 10:57:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/7] dt-bindings: arm: Add support for Qualcomm TGU trace To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, Rob Herring References: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> <20251219065902.2296896-2-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20251219065902.2296896-2-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI1MDAyNiBTYWx0ZWRfXxv3iYQk+9b1y QSQqvNt6qddq3insbqOTlGOxQbK3oXOa8wCaW3m65K/kNqIhagkJflcRE2SkQKDG5UaURXSBKh5 QV/QGlk9QMNQzNUVDkO0nGTuTlkhczKru2fvOFH4hiY3nwmyGFDZFgnbNZtrk3bTzTxqPi9QXN2 W2gxTtVFIrodPWtF3iKhwo/0REoGvP4Gepj4p3GB7RCfzQ+XVZkGm79YlOe+pzQ4yt8NTV8x9gU umOztIOtUu7GPk0G6zWUK10VfNYi2c+PbUlsd5CQccmRWCUpZKZJZg+VyN5Yz2LTfxmSJfeI3Ja GW+v+4NEwFqfPV/3v45+UvCxDVqVxM+ugBr3Nh/WbKsWVJs0StJ4v8IqSiPUlSoYMBNid1hyRLa YhaDB4zWvstI+Q5Mtoy1FpmeGlp8+GJriwVFukTqKm2qVqeYSDqx3UcIgAEzJr0R+0j9ylkGeYQ PL7m301l+MJPFFXox7g== X-Proofpoint-GUID: P_IV2PdEX9kQXTSOk_YjBhPASaqzbshX X-Authority-Analysis: v=2.4 cv=MKVtWcZl c=1 sm=1 tr=0 ts=694ca832 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IwjJGIUIzvyStixYlZUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: P_IV2PdEX9kQXTSOk_YjBhPASaqzbshX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_04,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512250026 On 12/19/2025 2:58 PM, Songwei Chai wrote: > The Trigger Generation Unit (TGU) is designed to detect patterns or > sequences within a specific region of the System on Chip (SoC). Once > configured and activated, it monitors sense inputs and can detect a > pre-programmed state or sequence across clock cycles, subsequently > producing a trigger. > > TGU configuration space > offset table > x-------------------------x > | | > | | > | | Step configuration > | | space layout > | coresight management | x-------------x > | registers | |---> | | > | | | | reserve | > | | | | | > |-------------------------| | |-------------| > | | | | priority[3] | > | step[7] |<-- | |-------------| > |-------------------------| | | | priority[2] | > | | | | |-------------| > | ... | |Steps region | | priority[1] | > | | | | |-------------| > |-------------------------| | | | priority[0] | > | |<-- | |-------------| > | step[0] |--------------------> | | > |-------------------------| | condition | > | | | | > | control and status | x-------------x > | space | | | > x-------------------------x |Timer/Counter| > | | > x-------------x > TGU Configuration in Hardware > > The TGU provides a step region for user configuration, similar > to a flow chart. Each step region consists of three register clusters: > > 1.Priority Region: Sets the required signals with priority. > 2.Condition Region: Defines specific requirements (e.g., signal A > reaches three times) and the subsequent action once the requirement is > met. > 3.Timer/Counter (Optional): Provides timing or counting functionality. > > Add a new tgu.yaml file to describe the bindings required to > define the TGU in the device trees. > > Reviewed-by: Rob Herring (Arm) > Signed-off-by: Songwei Chai > --- > .../devicetree/bindings/arm/qcom,tgu.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/qcom,tgu.yaml > > diff --git a/Documentation/devicetree/bindings/arm/qcom,tgu.yaml b/Documentation/devicetree/bindings/arm/qcom,tgu.yaml > new file mode 100644 > index 000000000000..5b6a58ebe691 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/qcom,tgu.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +# Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. Thanks, Jie > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/qcom,tgu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Trigger Generation Unit - TGU > + > +description: | > + The Trigger Generation Unit (TGU) is a Data Engine which can be utilized > + to sense a plurality of signals and create a trigger into the CTI or > + generate interrupts to processors. The TGU is like the trigger circuit > + of a Logic Analyzer. The corresponding trigger logic can be realized by > + configuring the conditions for each step after sensing the signal. > + Once setup and enabled, it will observe sense inputs and based upon > + the activity of those inputs, even over clock cycles, may detect a > + preprogrammed state/sequence and then produce a trigger or interrupt. > + > + The primary use case of the TGU is to detect patterns or sequences on a > + given set of signals within some region to identify the issue in time > + once there is abnormal behavior in the subsystem. > + > +maintainers: > + - Mao Jinlong > + - Songwei Chai > + > +# Need a custom select here or 'arm,primecell' will match on lots of nodes > +select: > + properties: > + compatible: > + contains: > + enum: > + - qcom,tgu > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - const: qcom,tgu > + - const: arm,primecell > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: apb_pclk > + > + in-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + additionalProperties: false > + > + properties: > + port: > + description: > + The port mechanism here ensures the relationship between TGU and > + TPDM, as TPDM is one of the inputs for TGU. It will allow TGU to > + function as TPDM's helper and enable TGU when the connected > + TPDM is enabled. > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + tgu@10b0e000 { > + compatible = "qcom,tgu", "arm,primecell"; > + reg = <0x10b0e000 0x1000>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + in-ports { > + port { > + tgu_in_tpdm_swao: endpoint{ > + remote-endpoint = <&tpdm_swao_out_tgu>; > + }; > + }; > + }; > + }; > +...