From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0117C43334 for ; Sat, 9 Jul 2022 14:48:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiGIOsU (ORCPT ); Sat, 9 Jul 2022 10:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiGIOsT (ORCPT ); Sat, 9 Jul 2022 10:48:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 868A6329 for ; Sat, 9 Jul 2022 07:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657378097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VLQSiBSYXaiYR0Ew7PdiVWeTwrVfhMdeI5Zm0PhD4Pg=; b=JYMIy/iQX1CzEVUnjLVyLQ0ng7F/i3tQdugOes5kwMatXtXHyyQCilAKbz6oBb8D51+rjH 90DXQr7sLHwdiyfO9co3s/NqEWHL/xr3X2wq5ZFbGnvF4g2wBuCazNFCvDNmCjp5WIGM7J WGHdaD8w7OcJoIpDPQDwZUAoiIOYnSQ= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-346-6hCIy6jQNba7ujLH2S3NBQ-1; Sat, 09 Jul 2022 10:48:16 -0400 X-MC-Unique: 6hCIy6jQNba7ujLH2S3NBQ-1 Received: by mail-ed1-f69.google.com with SMTP id t5-20020a056402524500b0043a923324b2so1118094edd.22 for ; Sat, 09 Jul 2022 07:48:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VLQSiBSYXaiYR0Ew7PdiVWeTwrVfhMdeI5Zm0PhD4Pg=; b=TFiIvr1h9u6jzbef/hPqeAq6fz20wFtJf4RitantQKGCpoQMSZt1w/VpRSTeVpjaVN wKwsTHhN14Ae2x5RhVzgAd1gUASArTir9JGvgnnrSyjvs0NfVlqqI5nVN9FAd9p55xZx cSgBKmWqJ2AJjAC1y1lHSI13osGfYtUwqa4rmaz4rEwyz+FVOkFUKr1cWdLGT/5E+BUg /kfcU/Z6h+kY8r+nyMTV0A8NSdc9p61BvJD1SPK9cBkZbUsapafYualUlJllkufhB+eB MdAe493p5bNFDxv3xAMmAsstKGZVsnzjfV6BQfgcueH6woEmRCLlsUOavHPXlTRPMo+f A9UQ== X-Gm-Message-State: AJIora9PYc/t5eKpEFuzyFUcYDSOV/a/XJHYEU+NhpF6XiHjb6jJuePl /vpK1QZcZxF3omOiOm54g0D/7J2XDd0wgUtHLnAOdsIyE99NryS3bmwWjc40OeGCLIOIrVrZ0Kf 94C+eIGi9QrayIQ68ia5Jtj44 X-Received: by 2002:a17:907:2cea:b0:72a:f6c9:8a26 with SMTP id hz10-20020a1709072cea00b0072af6c98a26mr9338385ejc.206.1657378095087; Sat, 09 Jul 2022 07:48:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vf63NX/Ri2F/NXTNyou1769psU2EzxKL8ExuUadMlJju8h/nj9voivpSW4cXtAwJ3feKTV0A== X-Received: by 2002:a17:907:2cea:b0:72a:f6c9:8a26 with SMTP id hz10-20020a1709072cea00b0072af6c98a26mr9338368ejc.206.1657378094902; Sat, 09 Jul 2022 07:48:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id 14-20020a170906318e00b00715705dd23asm665386ejy.89.2022.07.09.07.48.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Jul 2022 07:48:14 -0700 (PDT) Message-ID: <5c6c0516-7540-b668-9e7d-95db44ff336d@redhat.com> Date: Sat, 9 Jul 2022 16:48:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support Content-Language: en-US To: Andy Shevchenko , PaddyKP_Yao Cc: Mark Gross , Corentin Chary , Luke Jones , PaddyKP_Yao@asus.com, Platform Driver , Linux Kernel Mailing List , acpi4asus-user References: <20220708084816.1140540-1-PaddyKP_Yao@asus.com> <20220708090731.1237488-1-PaddyKP_Yao@asus.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/9/22 13:44, Andy Shevchenko wrote: > You have sent two patches with the same version, your submission > confuses everybody, which one are we supposed to consider? Also the From of this email: PaddyKP_Yao and the Signed-off-by: > > On Fri, Jul 8, 2022 at 11:08 AM PaddyKP_Yao wrote: >> >> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute >> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a >> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control >> it. The binding of mic-mute LED controls will be swithched with LED > > switched > >> trigger. > > ... > > Not reviewing code because of the above. > > Hint: `git format-patch -vX ...`, where X is a version number will > help. And when cooking a new version don't forget to add a changelog > between versions. >