From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B860B3C8728 for ; Mon, 23 Mar 2026 17:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287465; cv=none; b=G+jAoLAJSFaPhO4ajH6OHK3f2JdceDCQ4nVUgc+RAaNVDW0ZoyvX3jJZISxZVNBh+Yk2CtSOmsmwssFUwQyr9naouwdpq+N+r6D7zFkWTegTkV+NnwN5qKX/pPskOGnWyY9pJUye7VwvRIcShT6TYaKrJsjuM6Q5+Qtjdu3FikY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287465; c=relaxed/simple; bh=cK4s+aRJJfMSKQPfpYFlQXybNBTHKRc80Yo7MgBs5M4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=i8CxewGxICcbUmw6GgLWqoDHmwIYuck/3GqywziXRZ55AtbTqdKPZy9UbkhU2I6oLnEtU5RMbhEt66xG9opIqA1HRfibjoOW1/k2hGg01PnCw1iDF83t1gzfKYPqnRrmEIshCbAA88zm0mbr8CEUSrSmySVZ1o2HVb+dOnsGemY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=os8CgyaT; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="os8CgyaT" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so29169285e9.2 for ; Mon, 23 Mar 2026 10:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774287462; x=1774892262; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=cK4s+aRJJfMSKQPfpYFlQXybNBTHKRc80Yo7MgBs5M4=; b=os8CgyaT2Mfz2n5P0+B7XxDrx7gL3g88ShQLrki2M4e144FPKUn1XxUPfsHpLN5Zub G6xFyrd3BBBRL6Md6X2/9q5RJTzmxc9TjSNGYD1+jhpR7eujKs0ckniNbroFIIGMjfWw xeqOr6U3cbtdP26rQvI2AqYqFjcMTBY+j2UJfRLOXCaf9qAQ0jXTogahDA1gNEHKK3oA dD/UByI4Pmcl6j3iso9U2yz/K0aalDedmKSq6Du0PeFhD7+Cmz/00JYO69KIziaPgUGU 9zjzPYE7HwijkdjxVkn9lsk0M5mZcZ/mm2TY91Y50KcEPzo1GezdgEZGTQOGPEFe+PMN wcog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774287462; x=1774892262; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cK4s+aRJJfMSKQPfpYFlQXybNBTHKRc80Yo7MgBs5M4=; b=TKsHQKtQlvx8fD0wUPOOAKuvk7ToyIf7qjAbQQzFavl+5eYesbrd+uaGMEuTG0l6R6 eDDUXTkUi4wePdA7mCQMI3o+RULSLPsdJtlBbq6LHPwm7OZhnDVY2CAgoqt3fkzHlMhF 13wg/bvQACD6qqu6egtkV1QT0ul8NOKvvz2zPpZ4Oy4QO5S4vLIeqaKYGQciG4qBDEeT CE3iBWzkT7/ZDkhqQYQz1LAwC+wcrvONh/q6mJ+A1WBywJVkEtqRYfMP8zv/AXsgaa3f E6tUTuANSwYidoUWmNM0mbp4RJ6hLEjq32hM20ocuBMicn7pSLpv62lputEePscQY/6r gepg== X-Forwarded-Encrypted: i=1; AJvYcCXIARX1X5uFlmox0Nu+6wV0Lz833e7S6k9AWMDV51IT/lP88flObOpkhc/lURlymmRANG/CHAo2/zsNXlk=@vger.kernel.org X-Gm-Message-State: AOJu0YyUW6UK2AFdzJRTp/DgwwoGuE66AlAt+7d+OJDxr7nKUj3zuWjW Opivx5QTXwdWnQqbSBadmyaPekC8O4r+I5Fv8AH6YaKv/1pO455gchFsFXRjV8HIZ7o= X-Gm-Gg: ATEYQzyuIrRhHHcMdNxIxeLtwDd3w5Uce/9UUc5AhOBmoRlD46zhLJ/sHhhSb+5axMg 3ZcxzKuO/Jbi2ZkdTjUqtzDELmFNQX8Ll5Y3xZ44RZKwaMUeFhIvY56fYZs4Sa0Gb+Pdl6bqevb YlBJWjYddJqE0vsU1WmNH8jqhYa3/7KZjFHyMyHB+zofjGLuy95i/Hd+4nzjPN3yOkdWhrDO+rr hPkA8/fWDjGoMK0boq71Ki2vo0phZqUopyOuwSE6jCkag7n89X1p+qgpzSBAvCWEU9YrEzeqfWK +sIFDkbgeUbfy6giISglb8HV+UuzdefoTdyKghD0SHJBONLFgaEl8FRVHGjk5kG305/xNTGEf8T lfVvwBLpU2UCS//cGfh0aYHOw+p8Rvair8gIFfat7BBbLeyWbVV09SYIF4Dhspu9RLlbxVTSpJP LJnfus X-Received: by 2002:a05:600c:a4a:b0:485:5c6e:8a38 with SMTP id 5b1f17b1804b1-486fee0fbabmr173331945e9.17.1774287462040; Mon, 23 Mar 2026 10:37:42 -0700 (PDT) Received: from [10.76.209.31] ([151.35.182.48]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff1d6fbdsm80846685e9.33.2026.03.23.10.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 10:37:41 -0700 (PDT) Message-ID: <5c780b1be8a64f7862a421db5a1f5be861cb197c.camel@baylibre.com> Subject: Re: [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type From: Francesco Lavra To: Andy Shevchenko Cc: David Lechner , Jonathan Corbet , Shuah Khan , Jonathan Cameron , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Date: Mon, 23 Mar 2026 18:37:38 +0100 In-Reply-To: References: <20260317150316.3878107-1-flavra@baylibre.com> <20260317150401.3878294-1-flavra@baylibre.com> <4723284d-1e18-4a13-9ec1-878220af257e@baylibre.com> Organization: BayLibre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-23 at 18:49 +0200, Andy Shevchenko wrote: > On Mon, Mar 23, 2026 at 05:04:10PM +0100, Francesco Lavra wrote: > > On Sat, 2026-03-21 at 12:22 -0500, David Lechner wrote: > > > On 3/17/26 10:04 AM, Francesco Lavra wrote: >=20 > ... >=20 > > > > + * @IIO_SCAN_FORMAT_SIGNED_INT: Signed integer (two's complement). > > > > + * @IIO_SCAN_FORMAT_UNSIGNED_INT: Unsigned integer. >=20 > > > We could make this proper kernel doc format with one comment per > > > macro. > >=20 > > Actually, a set of related #defines can be documented with a single > > comment. I see a few examples doing that in include/linux/gfp_types.h > > and > > include/linux/fpga/fpga-mgr.h > >=20 > > > > +#define IIO_SCAN_FORMAT_SIGNED_INT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0's= ' > > > > +#define IIO_SCAN_FORMAT_UNSIGNED_INT=C2=A0=C2=A0=C2=A0'u' >=20 > ...or use enum >=20 > /** > =C2=A0* ...kernel-doc for enum... > =C2=A0*/ > enum { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0IIO_SCAN_FORMAT_SIGNED_IN= T =3D 's', > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0IIO_SCAN_FORMAT_UNSIGNED_= INT =3D 'u', > }; There is no standard kernel-doc format for anonymous enums.