From: Harsh Agarwal <quic_harshq@quicinc.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>, <quic_jackp@quicinc.com>,
<ahalaney@redhat.com>
Subject: Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle
Date: Wed, 8 Jun 2022 20:00:30 +0530 [thread overview]
Message-ID: <5c847f66-9caf-b303-2c25-b22e67a83c79@quicinc.com> (raw)
In-Reply-To: <c52d93db-e89a-24ba-725c-420641bd43af@omp.ru>
On 6/6/2022 4:30 PM, Sergey Shtylyov wrote:
> Hello!
>
> On 6/3/22 8:12 PM, Harsh Agarwal wrote:
>
>> Adding support for devm_of_usb_get_phy_by_phandle which allows
>> us to get PHY phandles of a device declared inside lookup_node.
>>
>> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
> [...]
>> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
>> index e4de6bc..2581c72 100644
>> --- a/include/linux/usb/phy.h
>> +++ b/include/linux/usb/phy.h
> [...]
>> @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
>> return ERR_PTR(-ENXIO);
>> }
>>
>> +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev,
> *extern inline*? :-O
> Shouldn't it be *static*?
This was a typo. Will change it. Thanks
>
>> + const char *phandle, u8 index, struct device_node *lookup_node)
>> +{
>> + return ERR_PTR(-ENXIO);
>> +}
>> +
>> static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev,
>> struct device_node *node, struct notifier_block *nb)
>> {
> MBR, Sergey
next prev parent reply other threads:[~2022-06-08 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 17:12 [PATCH v2 0/3] Add support for multiport controller Harsh Agarwal
2022-06-03 17:12 ` [PATCH v2 1/3] dt-bindings: usb: dwc3: Add support for multiport related properties Harsh Agarwal
2022-06-05 2:17 ` Rob Herring
2022-06-03 17:12 ` [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle Harsh Agarwal
2022-06-06 11:00 ` Sergey Shtylyov
2022-06-08 14:30 ` Harsh Agarwal [this message]
2022-06-03 17:12 ` [PATCH v2 3/3] usb: dwc3: Refactor PHY logic to support Multiport Controller Harsh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c847f66-9caf-b303-2c25-b22e67a83c79@quicinc.com \
--to=quic_harshq@quicinc.com \
--cc=ahalaney@redhat.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_jackp@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®