mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: shawn.lin@rock-chips.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, heiko@sntech.de, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	robh@kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Radxa E54C
Date: Mon, 12 Oct 2026 14:55:03 +0800	[thread overview]
Message-ID: <5c8a2985-e1aa-4062-bca8-fb05809b0d3c@rock-chips.com> (raw)
In-Reply-To: <20261012064010.1837103-1-amadeus@jmu.edu.cn>

Hi Chukun

在 2026/10/12 星期一 14:40, Chukun Pan 写道:
> Hi,
> 
>> I was checking all PCIe part of rockchip dts files and wondered why it's
>> marked as an always-on regulator. But if it's actually not, it'd be
>> better to improve it later. That would make reset rootport mechanism
>> work better.
> 
> Please refer to page 21 of the schematic[1]. The 3V3_PCIE regulator
> is enabled by the PMIC and cannot be controlled by the kernel. So I
> think it's correct to mark it as always-on.
> 
> [1] https://dl.radxa.com/e/e54c/hw/radxa_e54c_v1.2_schematic.pdf
> 

Thank you for providing the schematic. It does appear to be in an
uncontrolled state. Theoretically, PCIe control timing requires a
controllable power supply. The current design may cause trouble
enumerating certain devices due to always-on power. Unfortunately, this
board already has always-on power, so let's just leave it as is.

> Thanks,
> Chukun
> 


  reply	other threads:[~2026-10-12  7:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 10:00 [PATCH v2 0/2] " Chukun Pan
2026-08-20 10:00 ` [PATCH v2 1/2] dt-bindings: arm: " Chukun Pan
2026-08-20 10:00 ` [PATCH v2 2/2] arm64: dts: " Chukun Pan
2026-10-11  3:14   ` Shawn Lin
2026-10-12  6:40     ` Chukun Pan
2026-10-12  6:55       ` Shawn Lin [this message]
2026-10-09  6:40 ` [PATCH v2 0/2] " Chukun Pan
2026-10-10 12:10 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c8a2985-e1aa-4062-bca8-fb05809b0d3c@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®