From: Alex Elder <elder@ieee.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@kernel.org>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: qcom,ipa: Correct indentation and style in DTS example
Date: Mon, 24 Mar 2025 20:12:59 -0500 [thread overview]
Message-ID: <5c8fa538-6c04-4fcf-bcad-21fc1e2a0a9b@ieee.org> (raw)
In-Reply-To: <20250324125222.82057-1-krzysztof.kozlowski@linaro.org>
On 3/24/25 7:52 AM, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Looks identical with the exception of the white space change.
Thanks Krzysztof.
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> .../devicetree/bindings/net/qcom,ipa.yaml | 124 +++++++++---------
> 1 file changed, 62 insertions(+), 62 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 1a46d80a66e8..b4a79912d473 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -210,70 +210,70 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/interrupt-controller/arm-gic.h>
> - #include <dt-bindings/clock/qcom,rpmh.h>
> - #include <dt-bindings/interconnect/qcom,sdm845.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + #include <dt-bindings/interconnect/qcom,sdm845.h>
>
> - smp2p-mpss {
> - compatible = "qcom,smp2p";
> - interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>;
> - mboxes = <&apss_shared 6>;
> - qcom,smem = <94>, <432>;
> - qcom,local-pid = <0>;
> - qcom,remote-pid = <5>;
> + smp2p-mpss {
> + compatible = "qcom,smp2p";
> + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&apss_shared 6>;
> + qcom,smem = <94>, <432>;
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <5>;
>
> - ipa_smp2p_out: ipa-ap-to-modem {
> - qcom,entry-name = "ipa";
> - #qcom,smem-state-cells = <1>;
> - };
> -
> - ipa_smp2p_in: ipa-modem-to-ap {
> - qcom,entry-name = "ipa";
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - };
> + ipa_smp2p_out: ipa-ap-to-modem {
> + qcom,entry-name = "ipa";
> + #qcom,smem-state-cells = <1>;
> };
>
> - ipa@1e40000 {
> - compatible = "qcom,sc7180-ipa";
> -
> - qcom,gsi-loader = "self";
> - memory-region = <&ipa_fw_mem>;
> - firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn";
> -
> - iommus = <&apps_smmu 0x440 0x0>,
> - <&apps_smmu 0x442 0x0>;
> - reg = <0x1e40000 0x7000>,
> - <0x1e47000 0x2000>,
> - <0x1e04000 0x2c000>;
> - reg-names = "ipa-reg",
> - "ipa-shared",
> - "gsi";
> -
> - interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>,
> - <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
> - <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> - <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
> - interrupt-names = "ipa",
> - "gsi",
> - "ipa-clock-query",
> - "ipa-setup-ready";
> -
> - clocks = <&rpmhcc RPMH_IPA_CLK>;
> - clock-names = "core";
> -
> - interconnects =
> - <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
> - <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>,
> - <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
> - interconnect-names = "memory",
> - "imem",
> - "config";
> -
> - qcom,qmp = <&aoss_qmp>;
> -
> - qcom,smem-states = <&ipa_smp2p_out 0>,
> - <&ipa_smp2p_out 1>;
> - qcom,smem-state-names = "ipa-clock-enabled-valid",
> - "ipa-clock-enabled";
> + ipa_smp2p_in: ipa-modem-to-ap {
> + qcom,entry-name = "ipa";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> + };
> +
> + ipa@1e40000 {
> + compatible = "qcom,sc7180-ipa";
> +
> + qcom,gsi-loader = "self";
> + memory-region = <&ipa_fw_mem>;
> + firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn";
> +
> + iommus = <&apps_smmu 0x440 0x0>,
> + <&apps_smmu 0x442 0x0>;
> + reg = <0x1e40000 0x7000>,
> + <0x1e47000 0x2000>,
> + <0x1e04000 0x2c000>;
> + reg-names = "ipa-reg",
> + "ipa-shared",
> + "gsi";
> +
> + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>,
> + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
> + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "ipa",
> + "gsi",
> + "ipa-clock-query",
> + "ipa-setup-ready";
> +
> + clocks = <&rpmhcc RPMH_IPA_CLK>;
> + clock-names = "core";
> +
> + interconnects =
> + <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
> + <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>,
> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
> + interconnect-names = "memory",
> + "imem",
> + "config";
> +
> + qcom,qmp = <&aoss_qmp>;
> +
> + qcom,smem-states = <&ipa_smp2p_out 0>,
> + <&ipa_smp2p_out 1>;
> + qcom,smem-state-names = "ipa-clock-enabled-valid",
> + "ipa-clock-enabled";
> + };
next prev parent reply other threads:[~2025-03-25 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:52 Krzysztof Kozlowski
2025-03-24 20:26 ` Rob Herring (Arm)
2025-03-25 1:12 ` Alex Elder [this message]
2025-03-25 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8fa538-6c04-4fcf-bcad-21fc1e2a0a9b@ieee.org \
--to=elder@ieee.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®