From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBFB61B0100; Thu, 4 Jul 2024 14:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720104412; cv=none; b=IGFKbJZSwfbecKc1BmLm6DdYy8I7aSkQBBO+7uDeib+cgRJiv6rUFTbFoLTbf8AerqFX1BqfAI4mGzTXh0m0xv0ZOEnMBGxXBNyhdkBD/ryVAxYZM3tGTvWiz9ZQqCNUHgY9cxrqdz2hc7Jy0iQ43YzjwF261Vq8S382udWkPds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720104412; c=relaxed/simple; bh=08uX3JhFjLNCQFJ7WF6OjHhsgPeR/QKcbprTQAUZjfQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=s+0euyON1Ndcg0Cio0IOEL+e/DEPWf8aHwu0x+aBCR/y6n8qurKUTRvvcqttXHzMchLqXgFZTBdx1tZV8kSsE85uXnzZMk0e49cmsUgqwLv0HW3h5VvVd1DmeaiAZWeIrw19SOg8fj+UNG/N/sQ57xA92Fa1PiO8GfdTI+gK2Lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TElxrbi+; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TElxrbi+" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2c98a97d1ccso989316a91.0; Thu, 04 Jul 2024 07:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720104410; x=1720709210; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=DWycWJ9oxIcX2N4Ux3lOgR7vW96br71wvQA5vPsDWDs=; b=TElxrbi+SwhEJ/XeNk4/P91xY9i0hn1FCXwA9Nz/Wc6swpMyyuBo9hKvH6iANi6P3a bLk4TxWSsXb8koZGHNQuxQ5V9CWTH4lgb7jc6k3mxLSTjl8OeOhuvroLoGjg4uGKWnOA ryC/Yf6pFOeazz6unpsZ56j70UTEmnexx0OcRbJlqD+ERlqj0fnVdusb8YvbDhjW+6bO HngLapM8NcHMbf/TOMDFokCRXkTaeUdX40uvGqpi9YB0DskSAVFl8zsyuOGk6KPe6Ke3 GJ9aUBY7tSg0xsMKWxW1HPR4/v+dp3S6Hy7QGUsNJXOd9NWwygTGEgwkWG7axqGlyZ0v 3mRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720104410; x=1720709210; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DWycWJ9oxIcX2N4Ux3lOgR7vW96br71wvQA5vPsDWDs=; b=M692d+3CTo5PfVu5GHHulX0MVB8GDHI7wJ+FBrEKjKvMGdBivj0z99OaYjwSOilaUk WLxGygZroNavzW959CH1NqTgwiQdqHfadREt7p1QYEKuxgA+jxI4ks7Kzw++OqdCj2uw 0AydNpOvt/2R++K7g7LjdoVNn5CcqcCq+0KdmxUu9sTyPh774KJIhwGCHgdWKfWuYX/t W+Kx/mRjn938eFGgoa8itF2WCo4g4gypms65D/DtCQsI4WddAvD+Gg2L+1V7xtqpCRCv mZdZYANkO/Yc/uf3Oq5VwN8Lvy6FSEJYHkQwfjyS4V4a64ebXO2cGDi4RvCLzlRDVWNd 28Ng== X-Forwarded-Encrypted: i=1; AJvYcCWlkSGiQtVboi5Fgqns9VcfrZN5k9K4G/YXUUsVKmP+DX7dJIoxCuK0T4BLu6qdyyY7T035Z8oGVQzLCljdqeSpwy+vgPwxB39lm1/yAMgYtAnvzkR5mDB33OJpS7uKYnCxziMH X-Gm-Message-State: AOJu0YwsTm7zqnMftl1gYcgHu0/2V5FkRwXqiGu0LazIVcmeQ6OmU9p8 aSMbT6yJjkbnwc3OTlo/BLJ7xE6Y+9bUWe4Jo9LsBVF2qxfFbuoZ X-Google-Smtp-Source: AGHT+IEFfEHmjs4/vng6vnOIt6EX77Xb7wIPTz1d+Ty3lM88wDhbYmEvMFq+OVkHY5zkggtcz69SiQ== X-Received: by 2002:a17:90a:8c07:b0:2c8:2cd1:881b with SMTP id 98e67ed59e1d1-2c99f3c04dfmr2349201a91.20.1720104409980; Thu, 04 Jul 2024 07:46:49 -0700 (PDT) Received: from [10.40.5.113] ([89.207.175.15]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6b584624sm9867616a12.53.2024.07.04.07.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 07:46:48 -0700 (PDT) Message-ID: <5c92dcae-ec10-4652-a5e4-3f050774fc8b@gmail.com> Date: Thu, 4 Jul 2024 16:46:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3] net: dsa: mt7530: fix impossible MDIO address and issue warning To: Daniel Golle , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , DENG Qingfang , Sean Wang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Landen Chao , Frank Wunderlich , Rob Herring , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, regressions@lists.linux.dev References: <7e3fed489c0bbca84a386b1077c61589030ff4ab.1719963228.git.daniel@makrotopia.org> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <7e3fed489c0bbca84a386b1077c61589030ff4ab.1719963228.git.daniel@makrotopia.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/3/2024 12:44 AM, Daniel Golle wrote: > The MDIO address of the MT7530 and MT7531 switch ICs can be configured > using bootstrap pins. However, there are only 4 possible options for the > switch itself: 7, 15, 23 and 31. As in MediaTek's SDK the address of the > switch is wrongly stated in the device tree as 0 (while in reality it is > 31), warn the user about such broken device tree and make a good guess > what was actually intended. > > This is imporant also to not break compatibility with older Device Trees > as with commit 868ff5f4944a ("net: dsa: mt7530-mdio: read PHY address of > switch from device tree") the address in device tree will be taken into > account, while before it was hard-coded to 0x1f. > > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") > Signed-off-by: Daniel Golle > --- > Only tested on BPi-R3 (with various deliberately broken DT) for now! This seems like a whole lot of code just to auto-magically fix an issue that could be caught with a warning. I appreciate that most of these devices might be headless, and therefore having some attempt at getting functional networking goes a long way into allowing users to correct their mistakes. -- Florian