From: Dave Hansen <dave.hansen@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zhang.jia@linux.alibaba.com" <zhang.jia@linux.alibaba.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 1/1] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform
Date: Sat, 18 Feb 2023 09:19:58 -0800 [thread overview]
Message-ID: <5c98c586-680c-29de-2bd8-f95a7fc7e432@intel.com> (raw)
In-Reply-To: <a0242c82631b19f3de7a223d8dd38f21308cd3cc.camel@intel.com>
On 2/18/23 08:11, Zhang, Rui wrote:
> yes. I totally agree with this.
>
> But when showing the (cpu topology info and lscpu) problem below, I
> want to deliver a clear message that
> 1. there are two bugs and *both* of them are required in order to
> trigger the problem
> 2. this patch just fixes one of the bugs
That's fine, but please deliver that message in the cover letter, not
the patch changelog.
> Do you mean that I don't need to mention the x86_max_cores issue here?
Yes.
prev parent reply other threads:[~2023-02-18 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 16:37 [RFC PATCH 0/1] x86: cpu topology fix and question on x86_max_cores Zhang Rui
2023-02-17 16:37 ` [PATCH 1/1] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform Zhang Rui
2023-02-17 18:03 ` Dave Hansen
2023-02-18 16:11 ` Zhang, Rui
2023-02-18 17:19 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c98c586-680c-29de-2bd8-f95a7fc7e432@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®