From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74A7A3043CE for ; Mon, 23 Feb 2026 16:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771863712; cv=none; b=a83crUO8VcfXlISGglB3OECp3gp0m9HBofu+HQ/9o/S7o4wa+wptOpai+Yaf3/TsWKoLojPfLQUxatLlIL3Z0FYdIRc7cgJN63/QhIbnihSv9PZikKD2sWyGsSn0kE37sAmqlUjJemYeM3e70tltCmmZd2jIkQ26mUuBJ8+JVB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771863712; c=relaxed/simple; bh=cZdjdaZOcsXK6GsQf/mEIq7Qdmf7HWSKukscx0FcygU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eb1OwrpdGfgMmG6ReoDHirHxjtCc7anqSJuwzRmW8FdE82K3rRDYqz0unfaMievzSeT/pfdS2hKY51lk8VOf1jQV5o6PSmKh0vj8lT3oSiWeIFb2N/1vXWUnNxfa8fZHJX8pMKxTo7yjjxJVMoh12+6PJytKmGd0Bymtq8WGKgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AdjPnyqv; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AdjPnyqv" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43767807cf3so3424063f8f.1 for ; Mon, 23 Feb 2026 08:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771863710; x=1772468510; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=E12DLppc9zEwEUJULEgbOPg9LHuCkYx1Y+7qBt2BKRc=; b=AdjPnyqv0QCL36Ta+bRjeVvowMl5s9TcXCppQhECzdRxr9lx5R4RSUI1lebk/lc1rj sVUFf0sQegOvTqrirJZYRqIEVDvPIineIT+3OC7mdxrO7I6EDdKb1qgQt0nJl1NobAo1 xfjkKqIcV64S4FRlWdnTaBa7248Wi53ssF0xGgtXY+IwtQNbarcQFTxzRPfWJFkUq2Rn U0kFzy7eVLd612fGUbiyXXSrrjxupHSECEQYA5z+vFs/COu2AO/lwh6ZVs0nXVgT7ysV VedDkWY80HnnGF7N4kvGosnL9t3q4ebnKV39lPmH/DCRIcom2SGwHQGHaRYl/nzvVLfN Igrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771863710; x=1772468510; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E12DLppc9zEwEUJULEgbOPg9LHuCkYx1Y+7qBt2BKRc=; b=BmrTq6lG+mdPGggg+8cqDLo2fuFBNfQhrubODygvfUc96szsWwWZJBW58fQzprK+gh 68Flqunl5i/pilUR/7R/y/vkQ2tqsx8/x7sfyrE1FQ9/UxBi81WUZuWaZdMRPuigJCYv rSU1aNGJ272SsiGDsiQpdhrhO3p/khYIXhRpOo12HRYKTDWMmxiuZMnvuk4U+kGsqgw1 2guAoswknzmzhshwmNXDDLelmsKEpD9JUn7dnlMyvwLThUe8zqb80q2YZ5oflhvYtC/N 3EJnf9TdRhrPV/Qn8cr3wTtjKSVlvlAJiTaPouoD9C0tJFvMpZd20SKMtLOaPUSoRE4c QvWg== X-Forwarded-Encrypted: i=1; AJvYcCXYO06WddJP+G1/qaMBS6byqHEJ1/1e4qRII591mXb75QiRnBpE3DQD1Lkx/b/Mz0/gPNQPG+YUbo7pbQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3wEWlLftgvfPOa01+9KB33Gymv3BpQmna9KtsCwMvlri4nIi/ 1fWVpBN+23/UKjsG6k0RpXjiJkOs6diSbk/eqAVp/m/nBEbCVChZhn24H95Qwl/awqM= X-Gm-Gg: ATEYQzyGhWJb9eIrGNNhu/ImBmL2orzn0arhYHiLU4rBYrWRYbqrIWi+Kgzu1tnsmZU NNEma0zO85ke7BNZ6bDGDVV4cm/kGUKt/NRP1iw21QePYar0bABgSi0ty/i7DmRjvaYDKxTw+Vk FSbVOYyp/QXO8Q8BCU2IbhqZ/EO13Wag+bw/d5mGa1EDFv8/1Z+zdjPTku2mYkC15LLTDd47VAU 9OP3FXRZIZMvjOLMrHI5XyR3y4SS/7kKsIfU7yPXawIYyGbtGetDG9bNYNNySMoZSthc56zBvYU GbJ6nVNys8XudcFjD28bVG/W4xfJ9ar0VH6tPOIDlq8Nr8l94PdgI4j/xvI7kz4+08lp3uW/FZe 7kozbusCWSZxxW5YNDsQB8SANMc3YsDiCpu4rcR2o3mhgYJRxvhUgpSMl4r+pmbz+aTRTu4Pstd UmVHxi1miyxPErvLQ3V1nhd4PTCfUjeaSUDlo39FJt6z9UImBVTzyfRPyGH01gMg== X-Received: by 2002:a05:6000:230b:b0:437:71cc:a246 with SMTP id ffacd0b85a97d-4396f153cd2mr18596170f8f.10.1771863709655; Mon, 23 Feb 2026 08:21:49 -0800 (PST) Received: from ?IPv6:2804:5078:822:3100:58f2:fc97:371f:2? ([2804:5078:822:3100:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00e8bsm16973432f8f.15.2026.02.23.08.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 08:21:49 -0800 (PST) Message-ID: <5ca16692b304185df695e517434b16e59cb15a42.camel@suse.com> Subject: Re: [PATCH 2/2] selftests: livepatch: functions.sh: Workaround heredoc on older bash From: Marcos Paulo de Souza To: Joe Lawrence Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Shuah Khan , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Feb 2026 13:21:43 -0300 In-Reply-To: References: <20260220-lp-test-trace-v1-0-4b6703cd01a6@suse.com> <20260220-lp-test-trace-v1-2-4b6703cd01a6@suse.com> Autocrypt: addr=mpdesouza@suse.com; prefer-encrypt=mutual; keydata=mDMEZ/0YqhYJKwYBBAHaRw8BAQdA4JZz0FED+JD5eKlhkNyjDrp6lAGmgR3LPTduPYGPT Km0Kk1hcmNvcyBQYXVsbyBkZSBTb3V6YSA8bXBkZXNvdXphQHN1c2UuY29tPoiTBBMWCgA7FiEE2g gC66iLbhUsCBoBemssEuRpLLUFAmf9GKoCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk QemssEuRpLLWGxwD/S1I0bjp462FlKb81DikrOfWbeJ0FOJP44eRzmn20HmEBALBZIMrfIH2dJ5eM GO8seNG8sYiP6JfRjl7Hyqca6YsE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-23 at 10:42 -0500, Joe Lawrence wrote: > On Fri, Feb 20, 2026 at 11:12:34AM -0300, Marcos Paulo de Souza > wrote: > > When running current selftests on older distributions like SLE12- > > SP5 that > > contains an older bash trips over heredoc. Convert it to plain echo > > calls, which ends up with the same result. > >=20 >=20 > Acked-by: Joe Lawrence Thanks for the review Joe! >=20 > Just curious, what's the bash/heredoc issue?=C2=A0 All I could find via > google search was perhaps something to do with the temporary file > implementation under the hood. # ./test-ftrace.sh=20 cat: -: No such file or directory TEST: livepatch interaction with ftrace_enabled sysctl ... ^CQEMU: Terminated Somehow it doesn't understand the heredoc, but maybe I'm wrong... either way, the change has the same outcome, so I believe that it wasn't bad if we could change the cat for two echoes :) Either way, if Petr or you think that this should be left as it is, it's fine by me as well, I was just testing the change with an older rootfs/kernels. >=20 > -- > Joe >=20 > > Signed-off-by: Marcos Paulo de Souza > > --- > > =C2=A0tools/testing/selftests/livepatch/functions.sh | 6 ++---- > > =C2=A01 file changed, 2 insertions(+), 4 deletions(-) > >=20 > > diff --git a/tools/testing/selftests/livepatch/functions.sh > > b/tools/testing/selftests/livepatch/functions.sh > > index 8ec0cb64ad94..45ed04c6296e 100644 > > --- a/tools/testing/selftests/livepatch/functions.sh > > +++ b/tools/testing/selftests/livepatch/functions.sh > > @@ -96,10 +96,8 @@ function pop_config() { > > =C2=A0} > > =C2=A0 > > =C2=A0function set_dynamic_debug() { > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cat <<-EOF > "$SYSFS_DEBUG_= DIR/dynamic_debug/control" > > - file kernel/livepatch/* +p > > - func klp_try_switch_task -p > > - EOF > > + echo "file kernel/livepatch/* +p" > > > "$SYSFS_DEBUG_DIR/dynamic_debug/control" > > + echo "func klp_try_switch_task -p" > > > "$SYSFS_DEBUG_DIR/dynamic_debug/control" > > =C2=A0} > > =C2=A0 > > =C2=A0function set_ftrace_enabled() { > >=20 > > --=20 > > 2.52.0 > >=20