From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E01C10F0E for ; Tue, 9 Apr 2019 17:11:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 761A920850 for ; Tue, 9 Apr 2019 17:11:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbfDIRLD (ORCPT ); Tue, 9 Apr 2019 13:11:03 -0400 Received: from mga05.intel.com ([192.55.52.43]:48249 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbfDIRLC (ORCPT ); Tue, 9 Apr 2019 13:11:02 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 10:11:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,330,1549958400"; d="scan'208";a="129917005" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 09 Apr 2019 10:11:01 -0700 Received: from [10.54.74.33] (skuppusw-desk.jf.intel.com [10.54.74.33]) by linux.intel.com (Postfix) with ESMTP id 4476C580435; Tue, 9 Apr 2019 10:11:01 -0700 (PDT) Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v1 2/4] platform/x86: intel_pmc_ipc: Apply same width for offset definitions To: Andy Shevchenko , Darren Hart , platform-driver-x86@vger.kernel.org, Zha Qipeng , junxiao.chang@intel.com, linux-kernel@vger.kernel.org References: <20190409112515.84725-1-andriy.shevchenko@linux.intel.com> <20190409112515.84725-2-andriy.shevchenko@linux.intel.com> From: sathyanarayanan kuppuswamy Organization: Intel Message-ID: <5ca33880-a97f-24b4-1c48-92c1a649558b@linux.intel.com> Date: Tue, 9 Apr 2019 10:09:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409112515.84725-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/9/19 4:25 AM, Andy Shevchenko wrote: > Apply same width for offset definitions to make code more consistent. Looks good. > > Signed-off-by: Andy Shevchenko Reviewed-by: Kuppuswamy Sathyanarayanan > --- > drivers/platform/x86/intel_pmc_ipc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c > index eb0b342996ca..9007aa717586 100644 > --- a/drivers/platform/x86/intel_pmc_ipc.c > +++ b/drivers/platform/x86/intel_pmc_ipc.c > @@ -40,7 +40,7 @@ > * The ARC handles the interrupt and services it, writing optional data to > * the IPC1 registers, updates the IPC_STS response register with the status. > */ > -#define IPC_CMD 0x0 > +#define IPC_CMD 0x00 > #define IPC_CMD_MSI BIT(8) > #define IPC_CMD_SIZE 16 > #define IPC_CMD_SUBCMD 12 > @@ -101,8 +101,8 @@ > #define TELEM_SSRAM_SIZE 240 > #define TELEM_PMC_SSRAM_OFFSET 0x1B00 > #define TELEM_PUNIT_SSRAM_OFFSET 0x1A00 > -#define TCO_PMC_OFFSET 0x8 > -#define TCO_PMC_SIZE 0x4 > +#define TCO_PMC_OFFSET 0x08 > +#define TCO_PMC_SIZE 0x04 > > /* PMC register bit definitions */ > -- Sathyanarayanan Kuppuswamy Linux kernel developer