From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFCD63B4EAA for ; Wed, 17 Jun 2026 13:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781701432; cv=none; b=pm/vwqlSRnIwmEhOrww1nJyyVfMrHzwMsBdR+piTwZWeXI0k4VxQhqGezryXjO7CENcw0RVJ0hfhT2mOt/UTBsFpQI3U+V0NzXjNfJPq7tEH+MGt5dfi+MJXo1Ni7AgJj3UKFNBsNEAPDwA2ZYT8ND3FjQIqKoXECv3i76hl024= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781701432; c=relaxed/simple; bh=vkbVEGHGPYIWff5a+gnc1xm21wzif9CrOR85hzc44xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dgdj7v9HQi+XQ7/EvDadwpixO0F03c7oW7r3lcfGzaNA/mddpezO8y8AyAqkIBV1mFUrKY/DJrMVyTKP9f+Gg8VSg2WKXbfADhTMs0kFo92ulZOZHZPtfRJ80YhBD4qXdrc0YkVUxm9Tm9L3rwJiOCLzEU3j7L8XeERIaCdTEiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CfMnS92k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fqPwZdNs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CfMnS92k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fqPwZdNs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65H8VwZQ2056596 for ; Wed, 17 Jun 2026 13:03:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +oNFtPh1I858ThMD4359ZKal6EprR4daQKZRbaXsDx8=; b=CfMnS92kg9tnBUtb X9V7iumsmtCnjURVwW1DcA/XTS6ej6Axea/Klb2bhVLcixe8nrGTkhrY4RAYVLVi pFM7xNxzOhfTWMTtdJKaguyNEpLX/w0wpsaoJ0vtKnQ1aE7LFZYCIPilBxNL3iqz 8Mk8bRT44BQh2+gKNH0bIOzlgp68DvJ8tNlpTCzhEf/tNSWu9Nk9sw4JFoVDb9wN mgTal8O1G8xPSm0eM0+MBkwl63a/2udap/XBgk+kmQm4ddY3pQmaJqRg22/5IeAy T2ulnuUyAPmENfjLmwsPBK/n+TCb2S0AKUzFceeqTFvZg5wbSai3sedstuPu4HNL XOpfxw== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueesb83k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 13:03:49 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e6fe5ab3b0so933956a34.0 for ; Wed, 17 Jun 2026 06:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781701429; x=1782306229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+oNFtPh1I858ThMD4359ZKal6EprR4daQKZRbaXsDx8=; b=fqPwZdNsT8rt2KbXvtjuiJxUMYhmBAiKiz2IUAHb9Cx9+nHERsxTobTuLxHkOT6x0S Z3HOocFrAKDYopnZJ5NdUbCFXNkCv2PMAe76xKXPJjNkkgQedERfcfaQtfKII/rYd9CU XZHUkvYlLXFcGWm1LE2hO278eNrEi/BrfHrFvoOfWXTVcAcVIjiuDavhV+mP+FxQKrBY wp4fPWui+ztpWnXYEjW3VYDmJtp4XChQcou5LZiqfJV5ucDI/meT/pZXe6RLblfcVh1R fJIEehMH1yro1eKQLHQoSnXHGp5bZtvHIcpzCMivW1S8DuZh1qt8JJv+d5J2VjdkMedF Wh9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781701429; x=1782306229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+oNFtPh1I858ThMD4359ZKal6EprR4daQKZRbaXsDx8=; b=b19GKeMestUnNF2TGMoJqVDJj/vGxNKhN6mTEFLd5sZOFitRrNSVn3LyJYc5y+NFDZ Z8zKB0O39x9Zjy5MZHgADobkT8bL8n/nODTUYR8yzrZn7dTeN88XYZTgtRMcIjaS319Q qD89RaSyvDVFaTOoYIzSc1x5L1SkLArBbjlq9b0IedsX9WbyHlR94IPzS+qYjthfWQ5U K3KIUv4SKs+JF0r7gniuXPUuWaU62OHIwoNJE5o0WeHSrQBe6qGdJ5MSt4B5rFTOf4Gg iXCsIf6crI8pTX0DuCfBLOz5kbmIwYfPpZk69hT/AUZqOmqB3YxHw7uGdwFV8SVqKHUv R3kw== X-Forwarded-Encrypted: i=1; AFNElJ9lqLLgDqHAp2jT/hb1w9c+qr/CwK9gG4QSXyYsNgjHveBbK5EIi330h26PrbKqD7NFZg1kX0PQrJ9+AjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyqzJYwL+IsAMlqTzNy7+BzXgNMbrA4pxkwyIw35kOHEwa/yjSk E2QMsaCf0V5xZbQksBf0qsI772QsWTZKSQXbdPvntshJIEziEd4yNftXMuLNt39Y9fcG1PpQ56j FuOItqgIMgHPXTvap2qydQJcFElLhOY1ehqBaQMPBtnOlLcJWmXjHvGmfZzwleK+xGXo= X-Gm-Gg: Acq92OHVDFsvrKv2GOautyNRFu/Jn/7NCXk16nZTWFhvyaPIo/EpEVw072+TqIg/5LV FXwSxhA5VzwrFvF0+BU2ERk5BhQOBnQIgSt6JbN8lm49nObsb5M+LzyW11XJZcOVZlqqH3oj1Dp 4w/HL5/sxZNN9VPVI+vRliX5/6sa39nfO6HiERpuMDP8LrtX2ro6ohFPHBHfIBmZ3sBp4i8jNOX Sspy+6fzGLahNJap8QgvHEn+n1Ssawo2cdT5tOm9x2wCHNEEK0Fg6QR97ovhHkD8X1r1Oq3OSGT F3mmP0ieej17EU5/gfipk7bF/AwYk0jA0r/itduIDGG0yoxnRbGu0yLlWqdv9rlcKJede4hMiZy l9RcuRk8bVimwm9jRGTcqCLumrL4HIV34Mos= X-Received: by 2002:a05:6830:67f4:b0:7e6:cbe3:cbbe with SMTP id 46e09a7af769-7e90b4841d8mr2219598a34.7.1781701428964; Wed, 17 Jun 2026 06:03:48 -0700 (PDT) X-Received: by 2002:a05:6830:67f4:b0:7e6:cbe3:cbbe with SMTP id 46e09a7af769-7e90b4841d8mr2219518a34.7.1781701428207; Wed, 17 Jun 2026 06:03:48 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c063f9b2470sm75913666b.62.2026.06.17.06.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 06:03:47 -0700 (PDT) Message-ID: <5ca49c34-d0c9-441a-a8d5-6a334b6be58a@oss.qualcomm.com> Date: Wed, 17 Jun 2026 15:03:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] phy: qcom-qusb2: Fix SM6115 init sequence To: Iskren Chernev , Konrad Dybcio , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Greg Kroah-Hartman , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610-topic-8996_61x5_qusb2phy-v1-0-d7135980e78f@oss.qualcomm.com> <20260610-topic-8996_61x5_qusb2phy-v1-2-d7135980e78f@oss.qualcomm.com> <5b474af3-f651-4a64-a5b9-c18136e589eb@iskren.info> <6fb6f805-aea1-47e7-bb7c-bc5ecb2201ae@iskren.info> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6fb6f805-aea1-47e7-bb7c-bc5ecb2201ae@iskren.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDEyNCBTYWx0ZWRfX1sYwIKUn6ETq nViExixAd4VXqSURID5VooSoDxZPBzzinQjgHfnssLcOT6PZzWxk17CDOUyOFF2oY1/iXC3yzh0 dfq3G3X9JwzEsBj95BW2LuSjULuUiEo= X-Proofpoint-ORIG-GUID: IATnVSGQsM_T15qkeBb8YldnhxB-wqBu X-Authority-Analysis: v=2.4 cv=R6oz39RX c=1 sm=1 tr=0 ts=6a329b35 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=H8nO66aeAAAA:8 a=sh5-wexBAAAA:20 a=EUspDBNiAAAA:8 a=9_hlcAaISHj5Px0iC68A:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 a=29nWO70QIcuf0NxZitda:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: IATnVSGQsM_T15qkeBb8YldnhxB-wqBu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDEyNCBTYWx0ZWRfX3V6L3I/t4NnA 7Sddk2zbRFlaW0RkBoLQ/Z3zpZjoF1lMwNzYMX9RZsQBCmSrqzL0v6qXqnAj4ACU2YrQYi25reX 4tui1oY4C/u7GnUnFm/CJzH/f3WtXQJoTHO6EY/GzrtE6qe0WNY5k6rAUAYml6f2wqERSvOfR8B 8l5f+OUkgTVVMobeKk+d5aG4by1DEem2twCPSN9zyRjVW8EJsJ+gWuHeyyMWEuOYf9lbBoKbUCA RwNH+TynPqycidgG/Cc6KXZUuPOQctv2dtkc+E3cgECTPjqIgKazt3C9/JyYwMSCC80QVn+O9sK U9RDasYC9FJZGT4uMcKHUgtFNAY4BBf2glg2cqFxmv0MGAlLN//mJ6X4k2WMXNHAnIygwJs38OJ iI2IsRp4sxE3uZZoS7oOq2kZqNTdKk63PsHJoP01WiCa7qJk7DUK+neqwwwFSJGTJrDhnab0UOR qTkwc1AP1AtbgUBS38Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_01,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170124 On 6/17/26 2:48 PM, Iskren Chernev wrote: > > > On 6/15/26 1:44 PM, Konrad Dybcio wrote: >> On 6/14/26 2:29 PM, Iskren Chernev wrote: >>> >>> >>> On 6/10/26 3:04 PM, Konrad Dybcio wrote: >>>> From: Konrad Dybcio >>>> >>>> I don't know where the existing one came from, but it's apparently >>>> wrong, according to both docs and a downstream DT [1]. Fix it up. >>> >>> They came from DTB extracted from a running billie2 (OnePlus Nord N100): >>> [1] https://mainlining.dev/wp-content/uploads/2021/02/03_dtbdump_Qualcomm_Technologies_Inc._Bengal_SoC.dts >>> >>> The phone was bough early after launch, so it could have been wrong/updated later. >> >> Good to see you're still around! >> >> Looks like vendor tuning. I see that even the initial commit for >> 6115 had the init sequence I posted. And the OnePlus sources have >> what seems like a project-specific local copy of the DTSI: >> >> https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250/blob/oneplus/SM4250_Q_10.0/arch/arm64/boot/dts/vendor/qcom/bengal-usb.dtsi#L145 >> https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250/blob/oneplus/SM4250_Q_10.0/arch/arm64/boot/dts/vendor/20882/bengal-usb.dtsi#L148 >> >> To support that, we should add a new property to override the TUNEx >> registers - like e.g. qcom,hstx-trim-value that's already consumed > > My 2 cents - I never understood why init sequences are taboo in mainline > and widely used in downstream. I guess if it doesn't change (but across > what and who decides) it should be in code, but if it's "tuning" > - whatever that means, possibly depends on other components around, it > should be "configurable" via DT. The PHY has some electrical characteristics of its own, and then atop that are the characteristics of what's on the other end of it. Making all parameters configurable (i.e. raw init sequence) leads to duplication and pure blob seqeuences, whereas making everything constant leads to polluting the driver (if every device-specific seq was to be in C files) I think the current model of "override as necessary" is OK, especially since we can use the upstream leverage to require describing what the altered parameters actually change >> Would you like to look into that, or should I take this? > > You can take it, the other option is to mark a TODO, and if somebody > feels strongly about the binary value in a usb tune register s/he can > take up the task. Seems like OnePlus does.. actually, a number of vendors do. Sony does/used to do some tuning there too. > I just wanted to point out that the number didn't come from a random > number generator (or AI). I'm sorry if my language was too harsh. You used the best sources you had and had no reason to believe they were not the expected values. Konrad