From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55DB9C433E0 for ; Wed, 30 Dec 2020 05:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12AE2207B3 for ; Wed, 30 Dec 2020 05:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726305AbgL3Ff5 (ORCPT ); Wed, 30 Dec 2020 00:35:57 -0500 Received: from smtprelay0174.hostedemail.com ([216.40.44.174]:36730 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726144AbgL3Ff4 (ORCPT ); Wed, 30 Dec 2020 00:35:56 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 17FD6100E7B40; Wed, 30 Dec 2020 05:35:15 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: stone76_4003d5f274a2 X-Filterd-Recvd-Size: 3640 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Wed, 30 Dec 2020 05:35:14 +0000 (UTC) Message-ID: <5ca6c2d28f6cf091a676f8e7d8f14a933da0b267.camel@perches.com> Subject: Re: [PATCH] checkpatch: ignore warning designated initializers using NR_CPUS From: Joe Perches To: Peng Wang , apw@canonical.com Cc: linux-kernel@vger.kernel.org Date: Tue, 29 Dec 2020 21:35:13 -0800 In-Reply-To: <2eba2ec8531f440410ee8164aaf2ab754bd5a0d1.1609301434.git.rocking@linux.alibaba.com> References: <2eba2ec8531f440410ee8164aaf2ab754bd5a0d1.1609301434.git.rocking@linux.alibaba.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-30 at 12:13 +0800, Peng Wang wrote: > Some max_length wants to hold as large room as possible to > ensure enough size to tackle with the biggest NR_CPUS. As > an example below: > > kernel/cgroup/cpuset.c: > static struct cftype legacy_files[] = { >         { >                 .name = "cpus", >                 .seq_show = cpuset_common_seq_show, >                 .write = cpuset_write_resmask, >                 .max_write_len = (100U + 6 * NR_CPUS), >                 .private = FILE_CPULIST, >         }, > ... > } [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -7022,12 +7022,15 @@ sub process { >   > >  # use of NR_CPUS is usually wrong >  # ignore definitions of NR_CPUS and usage to define arrays as likely right > +# ignore designated initializers using NR_CPUS > + >   if ($line =~ /\bNR_CPUS\b/ && >   $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && >   $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && >   $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && >   $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && > - $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) > + $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/ && > + $line !~ /\s*\..*=.*\bNR_CPUS\b.*,$/) >   { >   WARN("NR_CPUS", >   "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); I wonder if it's worth it as there just aren't many of these: (6 total) $ git grep -P '\..*=.*\bNR_CPUS\b.*,\s*$' drivers/firmware/efi/efi.c: .cpu_bitmap = { [BITS_TO_LONGS(NR__CPUS)] = 0}, drivers/infiniband/hw/hfi1/sdma.c: .max_size = NR_CPUS, init/init_task.c: .nr_cpus_allowed= NR_CPUS, kernel/cgroup/cpuset.c: .max_write_len = (100U + 6 * NR_CPUS), kernel/cgroup/cpuset.c: .max_write_len = (100U + 6 * NR_CPUS), kernel/sysctl.c: .maxlen = NR_CPUS, It also seems it might be more sensible as: $line !~ /^.\s*\.\w+\s*=\s*.*\bNR_CPUS\b/ Which finds a couple more: $ git grep -P '^\s*\.\w+\s*=\s*.*\bNR_CPUS\b' arch/arm64/include/asm/processor.h: .fpsimd_cpu = NR_CPUS, \ arch/powerpc/kernel/prom_init.c: .max_cpus = cpu_to_be32(NR_CPUS), /* number of cores supported */ drivers/firmware/efi/efi.c: .cpu_bitmap = { [BITS_TO_LONGS(NR_CPUS)] = 0}, drivers/infiniband/hw/hfi1/sdma.c: .max_size = NR_CPUS, init/init_task.c: .nr_cpus_allowed= NR_CPUS, kernel/cgroup/cpuset.c: .max_write_len = (100U + 6 * NR_CPUS), kernel/cgroup/cpuset.c: .max_write_len = (100U + 6 * NR_CPUS), kernel/sysctl.c: .maxlen = NR_CPUS,