From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75DE1C54E49 for ; Sun, 10 May 2020 10:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5132C20735 for ; Sun, 10 May 2020 10:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbgEJKHr (ORCPT ); Sun, 10 May 2020 06:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725994AbgEJKHr (ORCPT ); Sun, 10 May 2020 06:07:47 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9831C061A0C for ; Sun, 10 May 2020 03:07:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 14D8C2A08D3 Subject: Re: [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings To: kbuild test robot , Matthias Brugger Cc: kbuild-all@lists.01.org, CK Hu , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <202005101033.xLBIJF9V%lkp@intel.com> <20200510025338.GA81310@f5ba873997c7> From: Enric Balletbo i Serra Message-ID: <5ca9a334-31d7-8878-f586-13d5020c24fc@collabora.com> Date: Sun, 10 May 2020 12:07:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200510025338.GA81310@f5ba873997c7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/20 4:53, kbuild test robot wrote: > From: kbuild test robot > > drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: 13032709e232 ("clk / soc: mediatek: Move mt8173 MMSYS to platform driver") > CC: Matthias Brugger > Signed-off-by: kbuild test robot Reviewed-by: Enric Balletbo i Serra > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 30e2206e11ce27ae910cc0dab21472429e400a87 > commit: 13032709e2328553970f0002df5edce6aac69425 [1266/7905] clk / soc: mediatek: Move mt8173 MMSYS to platform driver > > mtk-mmsys.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -25,10 +25,7 @@ static int mtk_mmsys_probe(struct platfo > > clks = platform_device_register_data(&pdev->dev, data->clk_driver, > PLATFORM_DEVID_AUTO, NULL, 0); > - if (IS_ERR(clks)) > - return PTR_ERR(clks); > - > - return 0; > + return PTR_ERR_OR_ZERO(clks); > } > > static const struct of_device_id of_match_mtk_mmsys[] = { >