From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9222C77B7A for ; Wed, 7 Jun 2023 09:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235070AbjFGJLE (ORCPT ); Wed, 7 Jun 2023 05:11:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240165AbjFGJKd (ORCPT ); Wed, 7 Jun 2023 05:10:33 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AAB1BD6; Wed, 7 Jun 2023 02:09:25 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 1F11E5FD63; Wed, 7 Jun 2023 12:09:24 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1686128964; bh=CumwjAyNcOyROazwWORMZqL/SIkAMktzdgFYOvd0NSA=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=IB7yP8h2qdh0bCixWjI5oZn9LGUy+PRnJS7dRyHwKW3sK/wVCDgbL4nhfYMJQpX3h mC6z2HwjdcEBikV+mwCJs8uRoT+wICXFLt7nhaVhh0RTi4tJA/1UpYw80kh62Uq/zM NX0o4F5zic0eU4W1hYSafCX2wNxIDSEfdcsXjPsa+M0IvBjcFeRewL4nqbbhdwdbZ9 YQePE4I43do8UExk4IGbL5m8EzUXc1tybLUKD+K8rofQjy5cxlntWchp1juebuthG2 PVwtr1fylnlCslB0pKiGTIF3Rfkzrqmcv1xhRZygsCphdt+knOkioMTPMWDA1PVrpF 0s5GtRsO6zSZw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 7 Jun 2023 12:09:23 +0300 (MSK) Message-ID: <5ca9eb2b-4bc8-5883-a029-3eeca905fe6e@sberdevices.ru> Date: Wed, 7 Jun 2023 12:04:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property Content-Language: en-US To: Krzysztof Kozlowski , Miquel Raynal CC: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , References: <20230606193507.35024-1-AVKrasnov@sberdevices.ru> <20230607095802.3adcd4f9@xps-13> <166bdc27-f77c-9076-f866-180cfa5bff76@sberdevices.ru> <08da4e86-433a-7d2e-25ff-ffa24221abdf@linaro.org> <835a3587-1e0f-64d7-1d1a-b639ae8b7307@sberdevices.ru> <2ca6e619-1d57-8fff-6176-9ee890e0d167@linaro.org> From: Arseniy Krasnov In-Reply-To: <2ca6e619-1d57-8fff-6176-9ee890e0d167@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/07 04:52:00 #21449589 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.06.2023 12:08, Krzysztof Kozlowski wrote: > On 07/06/2023 10:57, Arseniy Krasnov wrote: >> >> >> On 07.06.2023 11:53, Krzysztof Kozlowski wrote: >>> On 07/06/2023 10:40, Arseniy Krasnov wrote: >>>> Hello Miquel, >>>> >>>> On 07.06.2023 10:58, Miquel Raynal wrote: >>>> >>>>> Hi Arseniy, >>>>> >>>>> AVKrasnov@sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300: >>>>> >>>>>> Add description of 'nand-rb' property. Use "Fixes" because this property >>>>>> must be supported since the beginning. For this controller 'nand-rb' is >>>>>> stored in the controller node (not in chip), because it has only single >>>>>> r/b wire for all chips. >>>>> >>>>> Sorry if I mislead you in the first place, but you could definitely >>>>> have two chips and only one with RB wired. It needs to be defined in >>>>> the chips. >>>> >>>> Ok, so to clarify: is it ok, that in bindings this property will be placed in the >>>> chip, but in driver, i'm trying to read it from the controller node (thus in >>>> dts file it will be also in controller node)? >>> >>> No, because how would your DTS pass validation? I understand you did not >>> test the bindings, but this will improve, right? >> >> Ok, i'll follow DTS layout in the driver, "test the bindings" You mean "make dt_binding_check"? > > Yes. They were sent without testing. > > But please also test your DTS with dtbs_check. Got it! Thanks, Arseniy > > > Best regards, > Krzysztof >