From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE0EC67863 for ; Thu, 18 Oct 2018 19:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5BBB2054F for ; Thu, 18 Oct 2018 19:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZOvbkLs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5BBB2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727173AbeJSDlO (ORCPT ); Thu, 18 Oct 2018 23:41:14 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:36492 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbeJSDlN (ORCPT ); Thu, 18 Oct 2018 23:41:13 -0400 Received: by mail-yw1-f67.google.com with SMTP id z206-v6so1036606ywb.3; Thu, 18 Oct 2018 12:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FCneM4fQ+B4dxSypMB1sytKLOXrmUQdGBXY5xNYsN9Y=; b=IZOvbkLskaJzz7TbcderU35yY/GstxqYZtimLe4xjEOCEseiQdocs0vP5tXGTp7elV 6HUEfuYO/jx7i4RMsLO0oH3jqOr12Z1EtTYz0ll114IJObD6naegw2aogHJuBechY4Q+ 0QaYcSej3vQmdOj3TqnHhIor4YirZYeNOmsOL+RS4Lx0hxHHFexMgFDFkfSicj3LKYGQ SsPW9+CFSHjIhPbtBPDPHTYg/0KXpEc0s0ZQKOtFbEE/G1tq85UaNAhEgShFy83RMpCZ ZuSUyZlEwcMr8FLPufFVoyMnV0TfVHCMcgVKqX0KvSIy6wJ0b/UJlfOfq5No81dsJ2QT fLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FCneM4fQ+B4dxSypMB1sytKLOXrmUQdGBXY5xNYsN9Y=; b=H2ssEPjB98/X0jrLHj1hCsk1mJ2y0yVhCm/0682varAR1m0BRs3PG6DvEFwO/r0gEE rZGsadcP9B/5q5Vt2NUuZcVm7htszlTygFHgP+odPcbpVbBcM9WaFc8IIN1WVxcnpXLB mzqlrs5OdOcrYIvIZ7qym3wsrKIEDqxatZxR/J1qMlr6Gf8GcH2HtDKxx0c6Gpv9xa8Y eX2cKpd8bA+flFPKJXMlPmmRDfEzX0HFLejsS/ZWzoZ3+EKlqGeZjQGN2kH8p3qZY4bB kWEIzMPGIey1Tt8nPEYxAX1PAzFCJ6I0anupTki0qo4jR2ra9z0xhfOYzHbfBm8qWv58 BA+g== X-Gm-Message-State: ABuFfojHw4ODzBxIqQLtX8IXIwhuVjwyjvfGaYip5pSyrBEivTbddAdR BH1dC8XYawamQoXFDran8vcyjcfW X-Google-Smtp-Source: ACcGV62zCTpaYn4kLrKImMQaoszKZxDhTfMTfiaCtFxcWedwXsO52EmzLKaWacxuqBENSsny4vbVMg== X-Received: by 2002:a0d:e081:: with SMTP id j123-v6mr20166600ywe.267.1539891521922; Thu, 18 Oct 2018 12:38:41 -0700 (PDT) Received: from [10.67.48.209] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id x133-v6sm6422436ywg.66.2018.10.18.12.38.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 12:38:40 -0700 (PDT) Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_ To: LABBE Corentin Cc: andrew@lunn.ch, davem@davemloft.net, fugang.duan@nxp.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <1539875100-11121-1-git-send-email-clabbe@baylibre.com> <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com> <20181018184715.GA31736@Red> <20181018191612.GB31736@Red> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <5cb0731b-83c5-5ed5-d022-98f8627d1737@gmail.com> Date: Thu, 18 Oct 2018 12:38:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181018191612.GB31736@Red> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2018 12:16 PM, LABBE Corentin wrote: > On Thu, Oct 18, 2018 at 11:55:49AM -0700, Florian Fainelli wrote: >> On 10/18/2018 11:47 AM, LABBE Corentin wrote: >>> On Thu, Oct 18, 2018 at 11:39:24AM -0700, Florian Fainelli wrote: >>>> On 10/18/2018 08:05 AM, Corentin Labbe wrote: >>>>> Since commit 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed"), the fec driver is unable to get any link. >>>>> This is due to missing SPEED_. >>>> >>>> But SPEED_1000 is defined in include/uapi/linux/ethtool.h as 1000, so >>>> surely this would amount to the same code paths being taken or am I >>>> missing something here? >>> >>> The bisect session pointed your patch, reverting it fix the issue. >>> BUT since the fix seemed trivial I sent the patch without more test then compile it. >>> Sorry, I have just found some minutes ago that it didnt fix the issue. >>> >>> But your patch is still the cause for sure. >>> >> >> What you are writing is really lowering the confidence level, first >> Andrew is the author of that patch, and second "just compiling" and >> pretending this fixes a problem when it does not is not quite what I >> would expect. >> >> I don't have a problem helping you find the solution or the right fix >> though, even if it is not my patch, but please get the author and actual >> problem right so we can move forward in confidence, thanks! > > Sorry again, I wanted to acknoledge my error but I did it too fast and late. > And sorry to have confound you with Andrew. No worries, here to help, let us know what your bisection points to. THanks -- Florian