From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F938C433ED for ; Fri, 23 Apr 2021 15:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 051BE61465 for ; Fri, 23 Apr 2021 15:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243298AbhDWPBb (ORCPT ); Fri, 23 Apr 2021 11:01:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:37432 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243260AbhDWPAf (ORCPT ); Fri, 23 Apr 2021 11:00:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 41720B151; Fri, 23 Apr 2021 14:59:58 +0000 (UTC) Subject: Re: [PATCH 5/6] mm: Constify get_pfnblock_flags_mask and get_pfnblock_migratetype To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20210416231531.2521383-1-willy@infradead.org> <20210416231531.2521383-6-willy@infradead.org> From: Vlastimil Babka Message-ID: <5cb13e53-cd3f-a969-23c8-0e8a0788f242@suse.cz> Date: Fri, 23 Apr 2021 16:59:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210416231531.2521383-6-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/21 1:15 AM, Matthew Wilcox (Oracle) wrote: > The struct page is not modified by these routines, so it can be marked > const. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > include/linux/pageblock-flags.h | 2 +- > mm/page_alloc.c | 13 +++++++------ > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h > index fff52ad370c1..973fd731a520 100644 > --- a/include/linux/pageblock-flags.h > +++ b/include/linux/pageblock-flags.h > @@ -54,7 +54,7 @@ extern unsigned int pageblock_order; > /* Forward declaration */ > struct page; > > -unsigned long get_pfnblock_flags_mask(struct page *page, > +unsigned long get_pfnblock_flags_mask(const struct page *page, > unsigned long pfn, > unsigned long mask); > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0152670c6f04..4be2179eedd5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -474,7 +474,7 @@ static inline bool defer_init(int nid, unsigned long pfn, unsigned long end_pfn) > #endif > > /* Return a pointer to the bitmap storing bits affecting a block of pages */ > -static inline unsigned long *get_pageblock_bitmap(struct page *page, > +static inline unsigned long *get_pageblock_bitmap(const struct page *page, > unsigned long pfn) > { > #ifdef CONFIG_SPARSEMEM > @@ -484,7 +484,7 @@ static inline unsigned long *get_pageblock_bitmap(struct page *page, > #endif /* CONFIG_SPARSEMEM */ > } > > -static inline int pfn_to_bitidx(struct page *page, unsigned long pfn) > +static inline int pfn_to_bitidx(const struct page *page, unsigned long pfn) > { > #ifdef CONFIG_SPARSEMEM > pfn &= (PAGES_PER_SECTION-1); > @@ -495,7 +495,7 @@ static inline int pfn_to_bitidx(struct page *page, unsigned long pfn) > } > > static __always_inline > -unsigned long __get_pfnblock_flags_mask(struct page *page, > +unsigned long __get_pfnblock_flags_mask(const struct page *page, > unsigned long pfn, > unsigned long mask) > { > @@ -520,13 +520,14 @@ unsigned long __get_pfnblock_flags_mask(struct page *page, > * > * Return: pageblock_bits flags > */ > -unsigned long get_pfnblock_flags_mask(struct page *page, unsigned long pfn, > - unsigned long mask) > +unsigned long get_pfnblock_flags_mask(const struct page *page, > + unsigned long pfn, unsigned long mask) > { > return __get_pfnblock_flags_mask(page, pfn, mask); > } > > -static __always_inline int get_pfnblock_migratetype(struct page *page, unsigned long pfn) > +static __always_inline int get_pfnblock_migratetype(const struct page *page, > + unsigned long pfn) > { > return __get_pfnblock_flags_mask(page, pfn, MIGRATETYPE_MASK); > } >