From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45EB24EA90 for ; Mon, 9 Jun 2025 10:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749463893; cv=none; b=NFfcAy2QO2NYkcbuBR84DPniJCCKMlXhdsAiTEyANP8Rzh+LBHN0KYxZE1rhM1kD16Li/ZeaSgiw4XN7K4NiIxT/OiJlNMNpGzfkdU5aF5/wcybUj6q97VWjLOI26Gd9ULFZ85pQJ1CZCedx/1bKXhAr0qb6YbJYMaZ5dqVwe+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749463893; c=relaxed/simple; bh=An3OZnLy9ktVFQ8mmPPB+cTLsHAaqJU//ZVfHWfLkz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H6sGEzPnpVONgSrLPoK3EhpNFlKacfKWCIxfe8ZyKigJKqliM1giCaQZdmQ2ICeFBQtz9TtknT4yEixGA92jbTlNRLTXkorxRxxMZmb3nAq/UbpPStZoz0o1fNmzcumb1sa/R3/JP0NYCu8o80MOJHyLLb4Q/7EBtQe8tx9bmjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=M0yE3Fx3; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M0yE3Fx3" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-55367f03b0fso350310e87.2 for ; Mon, 09 Jun 2025 03:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749463890; x=1750068690; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=km/Og/aWOepgULZXU55OcArPvPOc4ZUj6YfVjtCIRPg=; b=M0yE3Fx3dfESLwmV6e+MeClYGMS+L6VSHF8+OijjSmcFZ0BoI0wBmJTqfbWUU+GroX 1H00pZHHSg37m9/p7VaCpDvA2QMh/sfoCYUwXx0LFd78BGZuJDuZkrMtqf79+UycVBJ2 8+yNVmdSHCn7tO+85tY4/kAjwNL5boVH3wKdNwsleXUcm1uM4hUU2jIJC4yayUE3D+hK gt2GAy7dr8XrLxSkXxl4js/ABeiXHdWgspK+P3zveE/HVcgS6WH+D7qrUARNXJetJDxu XTVjuUsAPbaXPc/NS9yWQTGEReSkhsmqYikCD3WU3aYrNLfSNxaV4owlUTbii8v1anPu xoWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749463890; x=1750068690; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=km/Og/aWOepgULZXU55OcArPvPOc4ZUj6YfVjtCIRPg=; b=cp+jUoJIpIO2S34lFOkL/R+d17jH0H4fAMrBN0M5Bm0JJ7Xhb/8rnfjeJT1urrfmRw 8WxFq9hP5lLe/mYUOJHtNIVj+LQ+WfKVuHWjbVOhxleikJ/kckVNaubPwv4zesXAcqBx HvICuR3sr1iESD/CpPRQPLaWi5eQltC7CtoELMDdaU7QUAXRKiX8XvCRDPTmMI5i6suj tkEOC+H/gDabeE+pCBbi69zt6VpxyAUjNiuuDfGkapNmplaSkTEpyn/wTP0GhIJYCNcF bCy9pnqR/lPwYvrIcrns9Lsciw2TTzRWLZ+46kYagcLDi/ZEwO5eDftnIOI/MVVIz4kf hhTA== X-Gm-Message-State: AOJu0YyasQJJ0a9kNi4yvW+SI4DWKmvztZXdUZHKhzTgUZi3BN/Jmcxe aMcU4Ol7eRdOU2XDwTx66oR9bw7DtUZEshmVyn+3H12hYithGiNtWcqmrK0YbOVEqxI= X-Gm-Gg: ASbGncuWavtek4AHZkgvAkAKM+eieXJc2aSpEo0XKosHOdvTkwnguuWRJenD0w+vKeJ LTj2zNIJhVOR5g/llAZlpQWTBFGQUgFnkUegGeCG9yu/MgxWCA4NsaKOwiSwbLhlTjDEmD9lOz8 liyljy63aA20TAJlGIvEKkY9bWs3m3taylX4E9047ReyB1/VSdeuVIbIm8NPNu23Y6kWFPzTEz8 rSAkQIrt0u+N5tzDDZVZPPGzk2MSTJfDpxkNGPOj9okoOUX/oKm/Ilk1TAizOLGKsSFqK8CI0Cc 1YGTCA7uD4HDWQHGLJRIg+IbpJpAlEST/H/yvg0kVBMqnsEwtpBIBy6EKKW7Vmto0rxLINw91Gd Ph+P3juGED6yb5HByRztS7OQ1KiaHQw== X-Google-Smtp-Source: AGHT+IE3CgUhWs9JJgxNaO2ezZdpoAhFkdMBw5PvlY45Fhn52F996AFzFwsp+F4iIUJCj3wWUYvArg== X-Received: by 2002:a05:651c:a0b:b0:32a:89bb:f8d9 with SMTP id 38308e7fff4ca-32ae32985a9mr10255741fa.6.1749463889794; Mon, 09 Jun 2025 03:11:29 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32ae1b0cf7fsm10081841fa.12.2025.06.09.03.11.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jun 2025 03:11:29 -0700 (PDT) Message-ID: <5cb2c3b5-9c19-48d0-bf48-634c74d704e3@linaro.org> Date: Mon, 9 Jun 2025 13:11:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss To: Vincent Knecht , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski References: <20250602-camss-8x39-vbif-v4-0-32c277d8f9bf@mailoo.org> <20250602-camss-8x39-vbif-v4-3-32c277d8f9bf@mailoo.org> <2884f55c-6b80-406a-ba21-aaa26297b1bf@linaro.org> <379f7434dadc22053afbf79734e8d96551b9e4e3.camel@mailoo.org> Content-Language: ru-RU From: Vladimir Zapolskiy In-Reply-To: <379f7434dadc22053afbf79734e8d96551b9e4e3.camel@mailoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Vincent. On 6/8/25 00:42, Vincent Knecht wrote: > Le vendredi 06 juin 2025 à 13:46 +0300, Vladimir Zapolskiy a écrit : >> Hello Vincent. > > Hi Vladimir, > thank you for the review. > >> On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote: >>> From: Vincent Knecht >>> >>> Add bindings for qcom,msm8939-camss in order to support the camera >>> subsystem for MSM8939. >>> >>> Reviewed-by: Krzysztof Kozlowski >>> Signed-off-by: Vincent Knecht >>> --- >>>   .../bindings/media/qcom,msm8939-camss.yaml         | 254 +++++++++++++++++++++ >>>   1 file changed, 254 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml >>> b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..59bf16888a8235495a2080e512ce179583bcd25d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml >>> @@ -0,0 +1,254 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/media/qcom,msm8939-camss.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm MSM8939 Camera Subsystem (CAMSS) >>> + >>> +maintainers: >>> +  - Vincent Knecht >>> + >>> +description: >>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms >>> + >>> +properties: >>> +  compatible: >>> +    const: qcom,msm8939-camss >>> + >>> +  reg: >>> +    maxItems: 11 >>> + >>> +  reg-names: >>> +    items: >>> +      - const: csid0 >>> +      - const: csid1 >>> +      - const: csid2 >>> +      - const: csiphy0 >>> +      - const: csiphy0_clk_mux >>> +      - const: csiphy1 >>> +      - const: csiphy1_clk_mux >>> +      - const: csi_clk_mux >>> +      - const: ispif >>> +      - const: vfe0 >>> +      - const: vfe0_vbif >> >> Please sort the list alphanumerically, accorting to the ASCII character set >> the underscore symbol precedes lower case letters. > > I followed "latest and greatest" qcom,x1e80100-camss bindings which > were largely reviewed and accepted, but if I must, so be it... Well, this particular dt binding is known to be imperfect, for instance see one of the series with a number of fix-ups: https://lore.kernel.org/all/20250502204142.2064496-1-vladimir.zapolskiy@linaro.org/ So, apparently the qcom,x1e80100-camss bindings shall be fixed in the given aspect as well before the first .dtsi/.dts user of it appears. > I guess this means I should also mod the DTSI from patch 4 ? > Should I also drop R-b tags ? I'm not sure about any granted Reviewed-by tags, this question should be addressed to the persons who gave the tags... The formal process says this [1]: Both Tested-by and Reviewed-by tags, once received on mailing list from tester or reviewer, should be added by author to the applicable patches when sending next versions. However if the patch has changed substantially in following version, these tags might not be applicable anymore and thus should be removed. Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned in the patch changelog (after the '---' separator). I would say the fixes should not be considered as substantial changes. [1] Documentation/process/submitting-patches.rst -- Best wishes, Vladimir