From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3C8244660 for ; Tue, 18 Nov 2025 00:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763425157; cv=none; b=QGERwxzLY2cL+KGVmGIJv1FqmJBIZ5pgOfmH96wVbAAtQOE/ORIpYibCh36v86nA1wOLNLg5eM1Xa9Zyn9GmH3OyDY+kXCVTG5i32RVS6F2VDnAeru19MsfzI1Rrv166VllLtSmEztAukdP2EamQpdwnBByoTJ1CzG7uqSd8bbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763425157; c=relaxed/simple; bh=NE51Ww4UYolV2eloWcZw9EaHWXEGQ0AGIHc5YZfdCaM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vv6oReibsKeFogeCS+IKEvBq/IiW3zJlwixklyFlGwh+efeaO+VlVGTo+qm4Zlvk5ebG2gc9wn4khm1X50+v4L8bmLcq+pF4k9V01PANV58gZwmOXgm5ouFa6kqXy2PH6QOsE0z5zVUNZGu2N0groOvB3KrbNuQ2vXhSzay8S70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=u/x9XyTN; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="u/x9XyTN" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7c76607b968so421562a34.3 for ; Mon, 17 Nov 2025 16:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1763425154; x=1764029954; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WfbAunHtQSMC12tNkJyQ4EuFtEBHZingQmrDRUQvvro=; b=u/x9XyTN0e1FR+j2frVyLU47gUYrZs7+yb4wSCYAFvEiL+g+Pu5uNz25BMr69o/fdT 1xpTvUg5lbxPEDc4JNbZA+kBudsHFqfJxqEdQB4DI7XR4GRPKu3oK6XJyBvF8D8fPVqA KlVZRm75xED3/wIHpDga4uvJgeICr9fSQR03Dt5XoN331VLKcfwC2eqb7Xeo+aA0bJ7x obyhy05I2FH2xnhq33M4LI8sydwqJbzNcnGtidl/FzwbW8gpQfK3txBZ2I1KNJPbFIL4 NwyqeEZT0A2tbustHcRByTNhjaw3rDO9rv7Jl+wnhLn258sPaHCRAmAzKhGFusXQGZPE 0+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763425154; x=1764029954; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WfbAunHtQSMC12tNkJyQ4EuFtEBHZingQmrDRUQvvro=; b=vvi5TPs272C4DInkJX3ug3B88nurYvAce4rvf9vF0tww9GptAMqJ+0uKlf4YnnOi/l Wviejb7EP+xmbFvzDM82WXPRQro3TFf/uzVddcLwxnW9YvKkZZ9qSZiS8B35m3RS9QAT vURRh4Z0M4T6OdLDdMEvt2hCywTupk2Qn8+pHZl1GdTYOeUOd5PC0vwVtvGmuva75Gdz Yn0F0Pu99xPDwP6rvtMiMXC6t9WVzhagMZxMQJ/v/VlRTenkl6ApX0IWDHGPCdeZM3Z1 RBhjkiMJubNYG2w+yFPrTdP9iHiROu4EBjAGkXXp9LUDV6hDWoT6PLn7yDSZEpp4slvL x36A== X-Forwarded-Encrypted: i=1; AJvYcCW/je7Bkb8qsUFMIjkkt/lVDBioOlSCHnkZz/ZHTeo/cmbNqYem/vcSPfbkIfkpKwpfDFRe+CFQN5UMitQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxumrVxUq0Ok35wil21myiG7ckYriYBx7jn+FGn7tW+FVvNOgm2 RiKQ8oLDhaMwnLs4+XxMB5hXj43OvkBnbvg3eBmx15uCyPi7Wq3Vfjpx0XsQ14jpQAY= X-Gm-Gg: ASbGnctZ8BtlpWOB/ZV7QD1QZ28wkel8fio0jBBwTUgxDdy1fF6gI4+eHf/q1tyJNGS FD7IEcHzFMSp/JFETbcjMc0FmRo3iS3oSTQMeb8eOYGqGCJ0Iz0jvraYoq7d4Q40S8cOMKWJSam S71Vz280SX4oDZFlVbH+O6Hge00ha+D2MamFZ4lOI5fTqxBmThTxl90xRb5F2vxVo5MEsJEGpdT Yw4rvSfUC2k4IV61IMxuOSC2GNtySedZbi5//I3/CA3xXpAIRelQ2YXUiSKjHNxauvBPJQeCsP7 ywLgBDIsfi9IWUAhpvBafgjzBIFoHzKRC6B6C70nxEl2eSrVd2Da97PjFZ76xACZ8wcQTO1sxYc 3F6TZN0NcOJr2PSj8B5RvtlbFg171v3RuhHjrsx7qAs1tchhpnzsoYNtm52vZwFPAxa9DyDeu7h o9NOqKibQedshqHMjUDaNqQAxvkKMJlGBUjUOD5CuWKTWqeJ72q+fST/vAPRBkP2obZFwCNp4= X-Google-Smtp-Source: AGHT+IHWlrolEv5LzL/t5TMhIIrUFVdsu/RnLAh79FM+odn19g1L+h2UPrr0XUBtACgyhVjNRMc3xw== X-Received: by 2002:a05:6830:34a1:b0:7c7:6217:5c60 with SMTP id 46e09a7af769-7c762176133mr3002294a34.25.1763425154062; Mon, 17 Nov 2025 16:19:14 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:8e86:179b:44b8:cc2b? ([2600:8803:e7e4:500:8e86:179b:44b8:cc2b]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c73a283c4dsm6084443a34.7.2025.11.17.16.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 16:19:13 -0800 (PST) Message-ID: <5cb6243e-f47b-48dc-9f43-299cde632e08@baylibre.com> Date: Mon, 17 Nov 2025 18:19:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1120 binding To: Jonathan Cameron , Ajith Anandhan Cc: nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251109141119.561756-1-ajithanandhan0406@gmail.com> <20251109141119.561756-2-ajithanandhan0406@gmail.com> <20251115183144.15b3e236@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20251115183144.15b3e236@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/15/25 12:31 PM, Jonathan Cameron wrote: > On Sun, 9 Nov 2025 19:41:18 +0530 > Ajith Anandhan wrote: > >> Add device tree binding documentation for the Texas Instruments >> ADS1120. >> >> The binding defines required properties like compatible, reg, and >> SPI configuration parameters. >> >> Signed-off-by: Ajith Anandhan >> --- >> .../bindings/iio/adc/ti,ads1120.yaml | 109 ++++++++++++++++++ >> 1 file changed, 109 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml >> new file mode 100644 >> index 000000000..2449094af >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml >> >> + >> + vref-supply: >> + description: | >> + Optional external voltage reference. Can be connected to either >> + REFP0/REFN0 or REFP1/REFN1 pins. If not supplied, the internal >> + 2.048V reference is used. > > How do you know which set of inputs is used? Looks like a register > needs to be programmed to pick between them. I would just make two supply properties for this, ref0-supply and ref1-supply > >> + >> + ti,avdd-is-ref: >> + type: boolean >> + description: | >> + If present, indicates that the AVDD supply voltage is of sufficient >> + quality and stability to be used as the voltage reference instead of >> + the internal reference. This allows the driver to select AVDD as the >> + reference source for potentially better performance. > > This one is interesting as I don't recall anyone arguing this made > sense before. In what way better performance? Are their boards out > there where this definitely makes sense to do? > Seems harmless to have the property even if no one ever uses it. But I would be curious to know the answers to those questions too.