From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26FBB25B088 for ; Wed, 15 Jul 2026 04:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784090828; cv=none; b=PRRdxm8KoBifRzOHKjy/xBq9g5KrutwFfg/jI2mAw9YfYzG6OkzSuBYNtb+XxP5QEXPmHsBuO4XGjb/a5QrY2qX3wdwl47r/AfjXWPerutkSBKuGKMkgn/MVEiAnHszcwIPW2Sa2XizgUvlmPFB5bhMKzAhIGgV2Ky3oQp0K2y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784090828; c=relaxed/simple; bh=r6ZuurDGK6UwF5g8/AftJ7m633AyRIHmPTqn4G6VrM0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=HCO7MCn1IuWqxUrmUjZbqhQ+ma+JGb1ZYCXeSD9VXJPblfbKlIMeGAjCfBWgdbBalaoFLLuMOtZn6eX7cS5eBBZTM69mrlxBxHkwdd5LuNr4n3f771DPX36klftKeVdbdvefCUiqqdZuROiYAi2TKCcV7c3KGXvyNNSmJ/PzLwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n5ZCNZje; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EHti3kjv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n5ZCNZje"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EHti3kjv" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F3kvLe2588234 for ; Wed, 15 Jul 2026 04:47:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jHLyLy9xJ9opQ7XzFo2f42ngzaMXGxPCwphpvbA63nc=; b=n5ZCNZjel4lcXrk4 1F/5Rx2sk7fLwooYlb4VBOJyPAigQi6sErTPzf/h9xZMPXAcrM+MeGE7nVNml+SM jsb26nvcGgu0dMKNdySuAWUnzAKk4bauivC7N6+OQKQPn5iOFneYICPoWAqmUht5 G/H4AX3PtcGPpVlBNls/1s7xyJNPmf5vwVHteDDgqkjRbao/at7vk0T776fylM1X 88+yBGES/EPEMf4RfZflIbA5QsyzFjkY/c4rZWQgDSpNAhqbcrOuqoH3nY2v5Lj6 YdS+VYQ5gOCCAMjAk4ZL/mUtzFG1c63CCC3Fkyjx/doXotMSq4VkHO2VN7uzpAs3 IAy4YQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fds9hsx8g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 04:47:06 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c20762d21so21453351cf.0 for ; Tue, 14 Jul 2026 21:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784090825; x=1784695625; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=jHLyLy9xJ9opQ7XzFo2f42ngzaMXGxPCwphpvbA63nc=; b=EHti3kjv6iG6TA6LMNGPUWv4MpIGnPeiQnoedHh6dsyLIlfumGwl7pcQb/8AZPock5 qewWHZUsv6QUNyS7oJG4C8pKjEaAE5zONHMq9F772eMu3svsLmEXqtyiXrcjRfbc10WW u9u2sjSG0ua0YH9HKtSGgrKd5SbMq4rgdl8psJRSNprkTMdBEkZDP5swxRGnB/XSr6Gs Uno45q1uP4+8xSnXcLR2SAdl5qZKbwcovoQ7Un6OFZyRRC1x3lQ854dh/LEwFpBwqVXf bFjiW13GA+pkcfWMeY49HLmTG104g6JzixGWCzvebpl5jVinzhBzZxTExZHYYr5L9hx2 RgIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784090825; x=1784695625; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jHLyLy9xJ9opQ7XzFo2f42ngzaMXGxPCwphpvbA63nc=; b=NA479IrQxLcARRxgkbJXDSO5vdwbb+hG05qpy3gOfHtRe/OnDrcKRZeAyTK3X6MSw4 OjgW1pzl6hC2rd6lwBxVtE9/s+S/amSgbiLljF3Np22ObNExAXLzz/CNpUuYC+f6kxUG j2aaEuHTFhfyshgDYBMrWxwn2siJGw52K6BSCbS/QZqdxqJwxMoQH5yVFOMQ7wjz7/yV QDGFXGiRwoLECHcGo8d7SurVUjB7u/XPIL/6rli349U6to4TbKHvKTBMAwFPJSFXzbup kXQobpdbymHVkBEJwVms19KzN2/BK12dAlCZrM8TRDCpE7HVvIoCVqfusIeqE7bxwZM/ iqmQ== X-Forwarded-Encrypted: i=1; AHgh+Rqx2l9HgfVXTIiKzNNK41k36fbz8cUmU1/LopOphyo8DGP0014jRQ//DTO3VZ7c8Hfc4RGDCBG3KZR7iIw=@vger.kernel.org X-Gm-Message-State: AOJu0YxdX2gwXc05zYw1difgW+Yxedprm2W2W91qtuFqkaP03lmyWVUF J49aFxl5LgjQtfK4aohpyZSiCdCSFGoekG0YYkdEFiUinP7eSlvG0NoJah5M5Ja4WPI9kvWW4eJ D+DtWvO9/8M46kEmYKPxVw+82d+l7axqJq5K5RAORMKiP8VPyGbKNgkl4VcIwTOQsGSU= X-Gm-Gg: AfdE7ckSMvGulSjUqyW1mf0CBj5Bec4TNyUPlQPZu8UFReQUWH7xpferG/vC6QC90lU qkbflSV+t/k+j7f4CXkP9lH73Qdg9cvxBB7MosyP9oJTS7LAUalqDB6G4QTWk/nU80pCjfFVkj4 nESONnqmdhAiVrfc2v8oK8ZiSwe/RNx2vSSOLyDUIxIb+TcvD1qKtVtHtCaJur1XhKZjIvXnGoN 25QRr7fy/TY5ClBJj8sP8vGbfH/XZRVbzmfHgoA6HuMmNT5SEITqCHgBGDFTal0aP7tOqnufTw6 bHAuCzdkBE+Qo8atoWqBWsOAzvXAr5ifmevRu9j/nCEO92QzhzrT618FgdHQevReGDmU1GFKYKf asCS4BV2KFPeZVv/MFQm3OSjrg3dArtcUryNxEEJm X-Received: by 2002:a05:622a:346:b0:51c:857f:9bfd with SMTP id d75a77b69052e-51cbf21096amr147710771cf.41.1784090825406; Tue, 14 Jul 2026 21:47:05 -0700 (PDT) X-Received: by 2002:a05:622a:346:b0:51c:857f:9bfd with SMTP id d75a77b69052e-51cbf21096amr147710621cf.41.1784090824912; Tue, 14 Jul 2026 21:47:04 -0700 (PDT) Received: from [192.168.1.110] ([178.197.223.174]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4950a322dc6sm129267505e9.10.2026.07.14.21.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 21:47:04 -0700 (PDT) Message-ID: <5cb62eb8-f8e7-4425-9e2c-2ae400bee031@oss.qualcomm.com> Date: Wed, 15 Jul 2026 06:47:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath10k: Drop redundant NULL check on devm_clk_get() To: Jeff Johnson , Jeff Johnson , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260705172405.119084-2-krzysztof.kozlowski@oss.qualcomm.com> <75ef4371-b66a-486a-8555-e3a3f6ee5d88@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: <75ef4371-b66a-486a-8555-e3a3f6ee5d88@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ib+3n2qa c=1 sm=1 tr=0 ts=6a5710ca cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=N6niishs+lR9UBL1FN3Qrw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=WNKottax_SZD0szvUdcA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: UkHcin_nUGOybMylmU8eg-yKqPrrBtob X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA0MSBTYWx0ZWRfX83uEn+xafWy+ VcaMH4kY3MztpdDkugAT1J0O6cvcxv1uLxvEOvQr7EpwsT0nNjOtPoKFkB7MqEtKUonJwEewuXM dcg7WGnh7N/+s11pd3tHQ0jJId8XoHA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA0MSBTYWx0ZWRfX1nz5Q3gaIer6 rx7fE05Evx1KFUdufMiCuURKdDxvHRGkkJjzoCVLAH5t6jT3iG+rTt7e1IWnSbxciqZJy77G45K EO168tMW+h9A4u8KI4sHuHhYOIg/jwH8mUVYUEw9fq9OumVJvTb8r3hb4N2FRK2XuYuSpP44ym5 LgvlP9UgGV9bS03AjbQdHN8Kx6q2ur0T+wOWKQm+CHa+M498hetTeSyko+qoXReoNLL/MWx9JFp DARMic4xkDsxrMOpszo1xt0iAwMJCJttUmhTdYbIto8WeGwTLUCBA8WOfncdU2wYTF0ubClhmJK HKk30heMCK/CkryNoBkYXl6w+YZPV6NmD8JADAOcxhomBvpNMUCLbSA8Tm+Alsxb9lrjO+4EkQg ijY/gfXqJ10weyrVv5LrYtz0CHLhDe7BB/Sh1Rv1bylkSJ7YdSr9P3AJHRQPhyP/nhChoSisZ9D ln6XqvfB+/ld5U7h82Q== X-Proofpoint-GUID: UkHcin_nUGOybMylmU8eg-yKqPrrBtob X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150041 On 14/07/2026 00:31, Jeff Johnson wrote: > On 7/5/2026 10:24 AM, Krzysztof Kozlowski wrote: >> devm_clk_get() does not return NULL (only valid clock or ERR pointer), >> so simplify the code to drop redundant IS_ERR_OR_NULL(). > > FWIW my AI review agent says: > Under !CONFIG_HAVE_CLK (x86 COMPILE_TEST), devm_clk_get() returns NULL; > IS_ERR(NULL) is false so clock_init() returns 0 with NULL clocks stored > > Perhaps the stub function in include/linux/clk.h should be updated to return > an ERR_PTR() instead of NULL? > Yes, that's on my todo list. Best regards, Krzysztof