From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E891423E35F for ; Fri, 20 Mar 2026 20:27:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774038441; cv=none; b=qdA5jyOgQF1dlPorZEgqHFwG1Uo25Hw5gYYdu2oCbgUbA2f/oofYhsF7RcthHFkK4MWUvUS74AC2B4c1Jfr4ZSEPskqDAuzi/vzM9MOxxhXph4TTfO7g4jUjQI37n1e8F+pngAC9OIv+bhvs2k0wtj2FiCTBl28vv1Gpt2joHuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774038441; c=relaxed/simple; bh=D99gn9PKYbfR7tpmv6pYb2l42qgPJ+5J9siVjCPWPBI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=DF7LwtNnR9Dk9cnKqQr6USFCeTkBwvalcdFs4gt29nhyn0YJsoXTr/DE/17/9t01A09QQRe9arw1PpgJ728NLCYTP/GPqIligDWOO7DFjgChio3B/GNXt8gyB5lx8tfZ2mvZEFuSTPbTI4miHRxdVvVh+3bp7k28kjTmkv0C6+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I/vn/3Ow; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oc5kqjMK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I/vn/3Ow"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oc5kqjMK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774038439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MB0+rSNGBKBl0fATluwYhfYR/8s/ouHiFI/my1DN3XI=; b=I/vn/3Ow3CDM8HGSty9AWgcrcOAJP+rn7KStCrNr25GvpRs4Q2KJIvB60i00LVTQqJsa6B e7eQE5CNMX8hT7xel8KQMxguqbigtCcWJoGRQVfFFfGoXSA5PPmuoFACPgpNLvE9gW1Heb oYU7gW0Tb91Zd0brPdQyd3UTT3EajJA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-320-cIVdPl_uPgyzJx3Z_zw_-A-1; Fri, 20 Mar 2026 16:27:17 -0400 X-MC-Unique: cIVdPl_uPgyzJx3Z_zw_-A-1 X-Mimecast-MFC-AGG-ID: cIVdPl_uPgyzJx3Z_zw_-A_1774038437 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89a108d17d2so121509936d6.2 for ; Fri, 20 Mar 2026 13:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774038437; x=1774643237; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=MB0+rSNGBKBl0fATluwYhfYR/8s/ouHiFI/my1DN3XI=; b=Oc5kqjMKVr9sS93TDNN3p0o0/enqii8sIwtIem8ofserADIYuPZf1QJr6Egtj3vwOw h0a6n70df+79ytoShNqp6H2W5Zx6XetITQw/nItMH5x4hBROeJN6x+jkUDZY7+i4xUKl 3MrZYV1KQE5jXoEulF/00i4MbDHxLwRJqEux6Y06OUGPxlEzIGLMKk8aEw+394sJg+LJ nxy0cRcNUX4fgnWdawhM3hjQ0c0cZsK/H+Tw4YgjWxFSFJjrBofL6W3+fmiHmyj7pZzB abvrvHyYUnf1cO94qQqbTFMDRM+pfTDMkW+PwKrG5KuFS3COSQK39+ILbukNppCPdDbQ r7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774038437; x=1774643237; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MB0+rSNGBKBl0fATluwYhfYR/8s/ouHiFI/my1DN3XI=; b=HsQRAMlCi6HYVdgBg/W8knmdtD55V6BUIUIsTyaXH8pmBKkqWQNr3cGtunTIYfOwzp ZGPTLhDE4fgP+gXakRKGjzWrDlsZ7iEAONSVAcVLDZPZJ4Pu1CMe7AokUFgk5nY2REz3 PMxKUvlezTGGhY66FSWIa5vN6bFZD5OQIIgRw7f5wX+FkjSaj3aGQsQ/58lauKP8XKN5 FWintqVUdw0AEySTB4OXaqdj6hM6fmhYxRhPg2FSpGUbnYXy6ybNGY1KLGXMZp9PkwyA 4lH2fkrIPK0krWkb5bFbPGdDcKpkVUy2NG2zrQR+pGOmv1sJgcpX1CnA7ssKmaoRrmQK yiLw== X-Forwarded-Encrypted: i=1; AJvYcCXWoINjxv+6ofbJAGUXB2gUIbyjn/m4JngvutmhXN3PDeojv4jNRwG+c9NRrDZ55kbxMNStzk4S12Sc82M=@vger.kernel.org X-Gm-Message-State: AOJu0YzSSJVNcAjwrP9VBmtelRzgZO6t1wikb3+rNL5u0jrCo/5llRbJ TsxzJssNSWcDpnmjvZNPDkl4Uqp6XxYNwqtEfEQfkv+vK+P3SQ7we6kqgFyYQ4FtxnHa4ynJ+IQ ZSkPwfQHDa+xu2W0GWUDVFNUAlFn1uoQua/q8WOu1mBlpGH2w3uAOIxo2zN+14sYCdw== X-Gm-Gg: ATEYQzzc5zkI8QYmpDjWuurDYQ88AfrqldUOG32ruhOM9BmXDDhdNXwAIRiy4hTS79d 18VdmJFPvXThhaB49dp9RtUunJQkKy83ufk3YA53LgyTfmXPD/gmz9SsXNp24fNlQzLwLeQulCd f1OsQCyKDkJqlnYjR+Ht1tMhzzSPFXAYuy+x7OLw9/HqH4yKtl1pxPpPvDJNMWcy17XcSfWKZgl sOIoNH/g+ShWrHu8JdYV1qt9X771AFh/MQ33Fq0P+2jOHXNM9CxwdfpxBdmUnnu0ZqdDuAs3Gt2 +DtoeO87EE22wSSMXtWq0hp/eIXimHEHFrckh7vzy5Z4gzUAlM2FRLXNbZfVZ8ruYIPv3iY3c/T rFbeaDazdgKtspboStA== X-Received: by 2002:ad4:5968:0:b0:89c:4ea7:a70f with SMTP id 6a1803df08f44-89c859e8c82mr70322156d6.14.1774038437327; Fri, 20 Mar 2026 13:27:17 -0700 (PDT) X-Received: by 2002:ad4:5968:0:b0:89c:4ea7:a70f with SMTP id 6a1803df08f44-89c859e8c82mr70321736d6.14.1774038436929; Fri, 20 Mar 2026 13:27:16 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c85361ac2sm27015786d6.41.2026.03.20.13.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 13:27:16 -0700 (PDT) Message-ID: <5cbcc6ff5b5dd72e0c4737cdff8ef897fa10cb61.camel@redhat.com> Subject: Re: [PATCH v11 43/65] drm-dyndbg: DRM_CLASSMAP_USE in nouveau From: lyude@redhat.com To: Jim Cromie , airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org, Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Date: Fri, 20 Mar 2026 16:27:15 -0400 In-Reply-To: <20260313132103.2529746-44-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> <20260313132103.2529746-44-jim.cromie@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul On Fri, 2026-03-13 at 07:20 -0600, Jim Cromie wrote: > Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with > DRM_CLASSMAP_USE.=C2=A0 This refs the defined & exported classmap, rather > than re-declaring it redundantly, and error-prone-ly. >=20 > This resolves the appearance of "class:_UNKNOWN_" in the control file > for the driver's drm_dbg()s. >=20 > Fixes: f158936b60a7 ("drm: POC drm on dyndbg - use in core, 2 > helpers, 3 drivers.") >=20 > Signed-off-by: Jim Cromie > --- > =C2=A0drivers/gpu/drm/nouveau/nouveau_drm.c | 12 +----------- > =C2=A01 file changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > b/drivers/gpu/drm/nouveau/nouveau_drm.c > index 5d8475e4895e..d205b58aff70 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -74,17 +74,7 @@ > =C2=A0#include "nouveau_uvmm.h" > =C2=A0#include "nouveau_sched.h" > =C2=A0 > -DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, > DD_CLASS_TYPE_DISJOINT_BITS, 0, > - "DRM_UT_CORE", > - "DRM_UT_DRIVER", > - "DRM_UT_KMS", > - "DRM_UT_PRIME", > - "DRM_UT_ATOMIC", > - "DRM_UT_VBL", > - "DRM_UT_STATE", > - "DRM_UT_LEASE", > - "DRM_UT_DP", > - "DRM_UT_DRMRES"); > +DRM_CLASSMAP_USE(drm_debug_classes); > =C2=A0 > =C2=A0MODULE_PARM_DESC(config, "option string to pass to driver core"); > =C2=A0static char *nouveau_config;