mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: y.oudjana@protonmail.com
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	gpiccoli@igalia.com, kernel@gpiccoli.net,
	loic.poulain@linaro.org, konrad.dybcio@somainline.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Add CPU cooling suppor,t
Date: Mon, 27 Sep 2021 18:45:29 -0300	[thread overview]
Message-ID: <5ccc4ea8-e000-b6b9-0781-dcde814eda96@igalia.com> (raw)
In-Reply-To: 

Hi Yassine, thanks for the patch! I was doing some experiments with a
dragonboard 820-based board, and without your patch, a CPU benchmark can
quickly cause overheating - throttling mechanism doesn't start and we
get a FW reset to a bad state (likely a HW protection mechanism).

I noticed that a similar patch including cooling maps is present in
Linaro's qcom tree [0], and it was submitted upstream [1], but there was
a re-submission [2] by Konrad that was merged and dropped the thermals
part. Based on some threads I read, it seems a FW lockup was detected
with the complete patch?

I'm not sure, so I'm looping Konrad / Loic / Bjorn here, to understand
better what made this portion of the patch to be dropped.
Anyway, I think worth to mention this in your commit message Yassine,
including perhaps a fixes tag like:

Fixes: 90173a954a22 ("arm64: dts: qcom: msm8996: Add CPU opps").

Also, I'm not sure why there was no response here or why it wasn't
merged, but if it helps, please have my:

Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

Thanks,


Guilherme


[0]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=release/qcomlt-4.14&id=2274c48c671

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/1595253740-29466-6-git-send-email-loic.poulain@linaro.org/

[2]
https://lore.kernel.org/linux-arm-msm/20210527194455.782108-2-konrad.dybcio@somainline.org/


             reply	other threads:[~2021-09-27 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 21:45 Guilherme G. Piccoli [this message]
2021-09-27 21:52 ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ccc4ea8-e000-b6b9-0781-dcde814eda96@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@gpiccoli.net \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®