From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A81C4361A for ; Fri, 4 Dec 2020 22:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE17B22287 for ; Fri, 4 Dec 2020 22:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388196AbgLDWkp (ORCPT ); Fri, 4 Dec 2020 17:40:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:60308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbgLDWko (ORCPT ); Fri, 4 Dec 2020 17:40:44 -0500 Subject: Re: [PATCHv2] clocksource: dw_apb_timer_of: add error handling if no clock available DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607121604; bh=78eutLpRIYyU0w+LYeVPxyo5gblVQmXiOQPscu5QgCs=; h=To:Cc:References:From:Date:In-Reply-To:From; b=kN98AJbtu0FuHkCcO512uYbfjmO+BR62SeH5HoOS9g/3RVvEMnKrLiTwSZXlePSgP 6815nLkPBQbjiPHfF2xJ7VSrmGX9QxF9e1YHZ0OelPKvMN6+ukkGET1Kc4dRYqcKHZ +MxTAv8EiOEkhxMHUaSS1gV8yx9xDw6/nXlULWgiAzuT4ytsSV6X2umjKkn5dWBLAD MSwagomHa/FOkhvKRdq0izSGRwITkhzYG1FJ5n42jTQFTYdhiFMLN0xOR5Z+4wzUcY DgoYxuKcMiCp6l/CgYtcSph9LXrs1dLlaeXQaHws1xBC1PHk3ncwAgIBJl4TXH3hj0 VX8Abmj9jtFLA== To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Jisheng.Zhang@synaptics.com, arnd@arndb.de References: <20201204153643.129897-1-dinguyen@kernel.org> From: Dinh Nguyen Message-ID: <5cd3bdf7-e514-267c-2243-d6f98f1b328a@kernel.org> Date: Fri, 4 Dec 2020 16:39:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/4/20 2:00 PM, Daniel Lezcano wrote: > On 04/12/2020 16:36, Dinh Nguyen wrote: >> commit ("b0fc70ce1f02 arm64: berlin: Select DW_APB_TIMER_OF") added the >> support for the dw_apb_timer into the arm64 defconfig. However, for some >> platforms like the Intel Stratix10 and Agilex, the clock manager doesn't >> get loaded until after the timer driver get loaded. Thus, the driver hits >> the panic "No clock nor clock-frequency property for" because it cannot >> properly get the clock. >> >> This patch adds the error handling needed for the timer driver so that >> the kernel can continue booting instead of just hitting the panic. >> >> Signed-off-by: Dinh Nguyen > > Did you have time to test the different combinations ? I did test both versions and did not see any difference between the two. On both versions, the kernel was able to continue to boot after trying to probe the timer driver. Dinh